feat: the application view page redirects to 404 if no application

bcgov · Apr 7, 2021 · 28d531c · 28d531c
1 parent ddef660
commit 28d531c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/app/pages/reporter/application/[applicationId]/version/[versionNumber]/view.tsx b/app/pages/reporter/application/[applicationId]/version/[versionNumber]/view.tsx
@@ -89,6 +89,12 @@ class ViewApplication extends Component<Props> {
     );
     const status =
       application?.applicationRevisionStatus?.applicationRevisionStatus;
+
+    if (!status) {
+      router.push('/404');
+      return null;
+    }
+
     const changesRequested = status === 'REQUESTED_CHANGES';
     const hasBeenReviewed = status !== 'SUBMITTED' && status !== 'DRAFT';
 

diff --git a/...sts/unit/pages/reporter/application/[applicationId]/version/[versionNumber]/view.test.tsx b/...sts/unit/pages/reporter/application/[applicationId]/version/[versionNumber]/view.test.tsx
@@ -40,7 +40,8 @@ const router: any = {
   query: {
     applicationId: 'testing',
     versionNumber: '1'
-  }
+  },
+  push: jest.fn()
 };
 
 describe('View submitted application page', () => {
@@ -51,6 +52,14 @@ describe('View submitted application page', () => {
     ).toBe(query);
   });
 
+  it('redirects to the 404 page if the application is missing', () => {
+    const r = shallow(
+      <ViewApplication query={{...query, application: null}} router={router} />
+    );
+    expect(r).toBeEmpty();
+    expect(router.push).toBeCalledWith('/404');
+  });
+
   it('does not show an application decision when unreviewed', () => {
     const r = shallow(
       <ViewApplication