fix: only validate past application dates if non-empty

bcgov · Nov 30, 2020 · 2c52762 · 2c52762
1 parent 97c06b1
commit 2c52762
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/app/containers/Admin/ReportingYear/reportingYearValidation.ts b/app/containers/Admin/ReportingYear/reportingYearValidation.ts
@@ -116,12 +116,11 @@ function validateApplicationDates(
     errors.addError(`${ERRORS.PAST_DATE} Application open time`);
   }
 
-  const closeDateIsPast =
-    validateFutureApplicationClose && isPastDate(closeDate);
   if (
     Boolean(closeDate) &&
     !uiSchema.applicationCloseTime['ui:disabled'] &&
-    closeDateIsPast
+    validateFutureApplicationClose &&
+    isPastDate(closeDate)
   ) {
     errors.addError(`${ERRORS.PAST_DATE} Application close time`);
   }