feat: refactoring e2e tests to use mock login

bcgov · Jan 8, 2021 · 31b19de · 31b19de
1 parent 8fd9a31
commit 31b19de
Show file tree

Hide file tree

Showing 19 changed files with 32 additions and 122 deletions.
diff --git a/app/cypress/integration/accessibility/admin-all-pages-accessibility.example.spec.js b/app/cypress/integration/accessibility/admin-all-pages-accessibility.example.spec.js
@@ -4,10 +4,7 @@ describe('When logged in as an admin', () => {
     cy.deployProdData();
     // The admin spec uses the same setup as the analyst
     cy.sqlFixture('fixtures/analyst-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/accessibility/analyst-all-pages-accessibility.example.spec.js b/app/cypress/integration/accessibility/analyst-all-pages-accessibility.example.spec.js
@@ -3,10 +3,7 @@ describe('When logged in as an analyst', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/analyst-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_ANALYST_USERNAME'),
-      Cypress.env('TEST_ANALYST_PASSWORD')
-    );
+    cy.mockLogin('analyst');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/accessibility/certifier-all-pages-accessibility.spec.js b/app/cypress/integration/accessibility/certifier-all-pages-accessibility.spec.js
@@ -4,10 +4,7 @@ describe('When logged in as a certifier(reporter)', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/certifier-access-setup');
-    cy.login(
-      Cypress.env('TEST_CERTIFIER_USERNAME'),
-      Cypress.env('TEST_CERTIFIER_PASSWORD')
-    );
+    cy.mockLogin('certifier');
     cy.useMockedTime(new Date(2020, 5, 10, 9, 0, 0, 0)); //May 10th at 9am
   });
 

diff --git a/app/cypress/integration/accessibility/reporter-all-pages-accessibility.spec.js b/app/cypress/integration/accessibility/reporter-all-pages-accessibility.spec.js
@@ -4,10 +4,7 @@ describe('When logged in as a reporter', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/reporter-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/admin-access-all-pages.spec.js b/app/cypress/integration/admin-access-all-pages.spec.js
@@ -3,10 +3,7 @@ describe('When logged in as an admin', () => {
     cy.cleanSchema();
     // The admin spec uses the same setup as the analyst
     cy.sqlFixture('fixtures/analyst-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/analyst-diffing.spec.js b/app/cypress/integration/analyst-diffing.spec.js
@@ -3,10 +3,7 @@ describe('When reviewing a submitted application as an analyst', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/analyst-diffing-setup');
-    cy.login(
-      Cypress.env('TEST_ANALYST_USERNAME'),
-      Cypress.env('TEST_ANALYST_PASSWORD')
-    );
+    cy.mockLogin('analyst');
     cy.visit(
       '/analyst/application-review?applicationId=WyJhcHBsaWNhdGlvbnMiLDFd&applicationRevisionId=WyJhcHBsaWNhdGlvbl9yZXZpc2lvbnMiLDEsMl0%3D&version=2'
     );

diff --git a/app/cypress/integration/application-form-validation.spec.js b/app/cypress/integration/application-form-validation.spec.js
@@ -21,10 +21,7 @@ describe('When reviewing a submitted application as an analyst', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/form-validation-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/application-production.spec.js b/app/cypress/integration/application-production.spec.js
@@ -6,10 +6,7 @@ describe('The production tab', () => {
   });
   beforeEach(() => {
     cy.sqlFixture('fixtures/production-draft-form-result-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
     const applicationId = window.btoa('["applications", 1]');
     const formResultId = window.btoa('["form_results", 4]');
     cy.visit(

diff --git a/app/cypress/integration/email.spec.js b/app/cypress/integration/email.spec.js
@@ -56,10 +56,7 @@ describe('Organisation access request emails', () => {
   beforeEach(() => {
     cy.cleanSchema();
     cy.sqlFixture('fixtures/email/org-access-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
     cy.request('DELETE', 'localhost:8025/api/v1/messages');
   });
   afterEach(() => {
@@ -136,10 +133,7 @@ describe('Draft application started email', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/email/draft-application-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
     cy.request('DELETE', 'localhost:8025/api/v1/messages');
     cy.wait(500);
   });
@@ -181,10 +175,7 @@ describe('Certification & Confirmation emails', () => {
     cy.sqlFixture('fixtures/email-setup');
   });
   beforeEach(() => {
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
   after(() => {
     cy.wait(1000);
@@ -310,10 +301,7 @@ describe('Certification email opt-out', () => {
     cy.sqlFixture('fixtures/email-setup');
   });
   beforeEach(() => {
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
   after(() => {
     cy.wait(1000);
@@ -362,10 +350,7 @@ describe('Application status change emails', () => {
     cy.deployProdData();
     cy.sqlFixture('fixtures/email/status-change-setup');
     cy.request('DELETE', 'localhost:8025/api/v1/messages');
-    cy.login(
-      Cypress.env('TEST_ANALYST_USERNAME'),
-      Cypress.env('TEST_ANALYST_PASSWORD')
-    );
+    cy.mockLogin('analyst');
     cy.wait(500);
   });
   afterEach(() => {

diff --git a/app/cypress/integration/form-errors-prevent-submit.spec.js b/app/cypress/integration/form-errors-prevent-submit.spec.js
@@ -3,10 +3,7 @@ describe('When logged in as a reporter', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.logout();
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
     cy.sqlFixture('fixtures/form-errors-prevent-submit-setup');
   });
 

diff --git a/app/cypress/integration/login-redirects.spec.js b/app/cypress/integration/login-redirects.spec.js
@@ -45,10 +45,7 @@ function testRedirectsForScopedPages(scope, pages) {
       cy.url().should('include', '/login-redirect');
       cy.url().should('include', `?redirectTo=${encodeURIComponent(url)}`);
 
-      cy.login(
-        Cypress.env[`TEST_${scope.toUpperCase()}_USERNAME`],
-        Cypress.env[`TEST_${scope.toUpperCase()}_PASSWORD`]
-      );
+      cy.mockLogin(scope);
 
       // As the SSO login page won't open in a frame in Cypress, the final redirect must be
       // tested indirectly as though we're following the auth callback:

diff --git a/app/cypress/integration/override-justification.spec.js b/app/cypress/integration/override-justification.spec.js
@@ -4,10 +4,7 @@ describe('When an applicaiton has errors', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/override-justification-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   after(() => {
@@ -54,10 +51,7 @@ describe('When an applicaiton has errors', () => {
   });
 
   it('The certifier should see the override notification', () => {
-    cy.login(
-      Cypress.env('TEST_CERTIFIER_USERNAME'),
-      Cypress.env('TEST_CERTIFIER_PASSWORD')
-    );
+    cy.mockLogin('certifier');
     const applicationId = window.btoa('["applications", 1]');
     cy.visit(`/certifier/certify?applicationId=${applicationId}&version=1`);
     cy.url().should('include', '/certifier/certify');
@@ -69,10 +63,7 @@ describe('When an applicaiton has errors', () => {
   });
 
   it('The reporter should see their override justification and be able to submit', () => {
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
     const applicationId = window.btoa('["applications", 1]');
     cy.visit(
       `/reporter/application?applicationId=${applicationId}&confirmationPage=true&version=1`
@@ -86,10 +77,7 @@ describe('When an applicaiton has errors', () => {
   });
 
   it('The analyst should see the override notification', () => {
-    cy.login(
-      Cypress.env('TEST_ANALYST_USERNAME'),
-      Cypress.env('TEST_ANALYST_PASSWORD')
-    );
+    cy.mockLogin('analyst');
     const applicationRevisionId = window.btoa(
       '["application_revisions", 1, 1]'
     );
@@ -111,10 +99,7 @@ describe('When an applicaiton does not have errors', () => {
     cy.deployProdData();
     cy.sqlFixture('fixtures/reporter-all-access-setup');
     cy.sqlFixture('fixtures/set-legal-disclaimer-true');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/page-access.spec.js b/app/cypress/integration/page-access.spec.js
@@ -2,10 +2,7 @@ describe('When logged in as a reporter', () => {
   beforeEach(() => {
     cy.cleanSchema();
     cy.sqlFixture('dev/user');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => cy.logout());
@@ -19,10 +16,7 @@ describe('When logged in as a reporter', () => {
 
 describe('When logged in as an analyst', () => {
   before(() => {
-    cy.login(
-      Cypress.env('TEST_ANALYST_USERNAME'),
-      Cypress.env('TEST_ANALYST_PASSWORD')
-    );
+    cy.mockLogin('analyst');
   });
 
   after(() => cy.logout());
@@ -36,10 +30,7 @@ describe('When logged in as an analyst', () => {
 
 describe('When logged in as an admin', () => {
   before(() => {
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
   });
 
   after(() => cy.logout());

diff --git a/app/cypress/integration/product-benchmark.spec.js b/app/cypress/integration/product-benchmark.spec.js
@@ -3,10 +3,7 @@ describe('The products and benchmark page', () => {
     cy.logout();
     cy.cleanSchema();
     cy.sqlFixture('fixtures/products-benchmarks-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
     cy.visit('/admin/products-benchmarks');
     cy.get('#page-content');
   });
@@ -34,10 +31,7 @@ describe('The benchmark modal', () => {
     cy.logout();
     cy.cleanSchema();
     cy.sqlFixture('fixtures/products-benchmarks-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
     cy.visit('/admin/products-benchmarks');
     cy.get('#page-content');
   });
@@ -103,10 +97,7 @@ describe('The linking modal', () => {
     cy.logout();
     cy.cleanSchema();
     cy.sqlFixture('fixtures/products-benchmarks-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
     cy.visit('/admin/products-benchmarks');
     cy.get('#page-content');
   });
@@ -146,10 +137,7 @@ describe('The Create Product modal', () => {
     cy.logout();
     cy.cleanSchema();
     cy.sqlFixture('fixtures/products-benchmarks-setup');
-    cy.login(
-      Cypress.env('TEST_ADMIN_USERNAME'),
-      Cypress.env('TEST_ADMIN_PASSWORD')
-    );
+    cy.mockLogin('admin');
     cy.visit('/admin/products-benchmarks');
     cy.get('#page-content');
   });

diff --git a/app/cypress/integration/reporter-access-all-pages.spec.js b/app/cypress/integration/reporter-access-all-pages.spec.js
@@ -4,10 +4,7 @@ describe('When logged in as a reporter', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/reporter-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => {

diff --git a/app/cypress/integration/reporter-certifier-access.spec.js b/app/cypress/integration/reporter-certifier-access.spec.js
@@ -4,10 +4,7 @@ describe('When logged in as a certifier(reporter)', () => {
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/certifier-access-setup');
-    cy.login(
-      Cypress.env('TEST_CERTIFIER_USERNAME'),
-      Cypress.env('TEST_CERTIFIER_PASSWORD')
-    );
+    cy.mockLogin('certifier');
     cy.useMockedTime(new Date(2020, 5, 10, 9, 0, 0, 0)); //May 10th at 9am
   });
 

diff --git a/app/cypress/integration/reporter-select-reporting-year.spec.js b/app/cypress/integration/reporter-select-reporting-year.spec.js
@@ -3,10 +3,7 @@ describe('When the reporter is viewing a list of facilities & applications', ()
     cy.cleanSchema();
     cy.deployProdData();
     cy.sqlFixture('fixtures/reporter-all-access-setup');
-    cy.login(
-      Cypress.env('TEST_REPORTER_USERNAME'),
-      Cypress.env('TEST_REPORTER_PASSWORD')
-    );
+    cy.mockLogin('reporter');
   });
 
   afterEach(() => {

diff --git a/app/server/postgraphile/authenticationPgSettings.js b/app/server/postgraphile/authenticationPgSettings.js
@@ -63,7 +63,7 @@ const authenticationPgSettings = (req) => {
     };
   }
 
-  if (AS_PENDING || allowCypressForRole('pending', req)) {
+  if (AS_PENDING || allowCypressForRole('user', req)) {
     return {
       'jwt.claims.sub': '00000000-0000-0000-0000-000000000000',
       'jwt.claims.user_groups': 'Pending Analyst',

diff --git a/docs/stack.md b/docs/stack.md
@@ -226,7 +226,7 @@ A `cypress.env.json` file is available on the CAS Scrum team SharePoint (TODO: S
 - Start the database
 - Deploy the development data using `.bin/deploy-data.sh -p -dev`
 - Start the application using your favorite command. On CI, it will run it in production mode, with auth enabled. While developing, however, you can run `yarn dev NO_AUTH` in most cases
-- The feature flag `yarn dev NO_MATHJAX` is available for running Cypress tests
+- The feature flag `yarn dev NO_MATHJAX AS_CYPRESS` is available for running Cypress tests
 - These flags block mathjax components that often cause a false failed response from the e2e tests.
 - Run `yarn cypress` to open the Cypress UI