feat: Nav landmark accessibility

bcgov · Aug 20, 2020 · 429d1c1 · 429d1c1
1 parent 5a5618c
commit 429d1c1
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 2 deletions.
diff --git a/app/components/Layout/Header.tsx b/app/components/Layout/Header.tsx
@@ -33,7 +33,7 @@ const HeaderLayout = ({isLoggedIn = false, isRegistered = false, children}) => {
   return (
     <header>
       <div className="nav-header">
-        <nav>
+        <nav aria-label="Main">
           <div className="header-left">
             <Link href="/">
               <a>

diff --git a/app/components/Layout/Subheader.tsx b/app/components/Layout/Subheader.tsx
@@ -10,7 +10,7 @@ const Subheader = () => {
 
   return (
     <div>
-      <nav className="navigation-main" id="navbar">
+      <nav className="navigation-main" id="navbar" aria-label="Secondary">
         <div className="container">
           <ul>
             <li className={asPath === DASHBOARD_PATH ? 'active' : ''}>

diff --git a/app/tests/integration/__snapshots__/Storyshots.test.ts.snap b/app/tests/integration/__snapshots__/Storyshots.test.ts.snap
@@ -20,6 +20,7 @@ Array [
           className="jsx-2584110530 nav-header"
         >
           <nav
+            aria-label="Main"
             className="jsx-2584110530"
           >
             <div
@@ -529,6 +530,7 @@ Array [
           className="jsx-2584110530 nav-header"
         >
           <nav
+            aria-label="Main"
             className="jsx-2584110530"
           >
             <div
@@ -1022,6 +1024,7 @@ Array [
           className="jsx-2584110530 nav-header"
         >
           <nav
+            aria-label="Main"
             className="jsx-2584110530"
           >
             <div
@@ -1133,6 +1136,7 @@ Array [
         </div>
         <div>
           <nav
+            aria-label="Secondary"
             className="jsx-2326483044 navigation-main"
             id="navbar"
           >
@@ -1687,6 +1691,7 @@ Array [
           className="jsx-2584110530 nav-header"
         >
           <nav
+            aria-label="Main"
             className="jsx-2584110530"
           >
             <div
@@ -2029,6 +2034,7 @@ Array [
           className="jsx-2584110530 nav-header"
         >
           <nav
+            aria-label="Main"
             className="jsx-2584110530"
           >
             <div

diff --git a/app/tests/unit/components/Layout/__snapshots__/Header.test.tsx.snap b/app/tests/unit/components/Layout/__snapshots__/Header.test.tsx.snap
@@ -8,6 +8,7 @@ exports[`It matches the last accepted Snapshot 1`] = `
     className="jsx-2584110530 nav-header"
   >
     <nav
+      aria-label="Main"
       className="jsx-2584110530"
     >
       <div

diff --git a/app/tests/unit/components/Layout/__snapshots__/Subheader.test.tsx.snap b/app/tests/unit/components/Layout/__snapshots__/Subheader.test.tsx.snap
@@ -3,6 +3,7 @@
 exports[`The Subheader matches the last accepted Snapshot 1`] = `
 <div>
   <nav
+    aria-label="Secondary"
     class="jsx-2326483044 navigation-main"
     id="navbar"
   >
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,6 +8,7 @@ exports[`It matches the last accepted Snapshot 1`] = ` @@
         className="jsx-2584110530 nav-header"
       >
         <nav
+          aria-label="Main"
           className="jsx-2584110530"
         >
           <div
@@ Expand Down @@