fix: production amount and emissions allocated should be allowed to be 0

bcgov · Aug 4, 2020 · 5f1f86b · 5f1f86b
1 parent 8007d06
commit 5f1f86b
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/app/tests/integration/Forms/__snapshots__/Form.test.tsx.snap b/app/tests/integration/Forms/__snapshots__/Form.test.tsx.snap
@@ -2302,7 +2302,7 @@ exports[`Form should match the snapshot with the production form 1`] = `
                       onKeyDown={[Function]}
                       onMouseUp={[Function]}
                       type="text"
-                      value="-60,000,000"
+                      value="20,000,000"
                     />
                     <span
                       className="font-italic text-muted"

diff --git a/app/tests/unit/containers/Applications/__snapshots__/ApplicationDetailsPdf.test.tsx.snap b/app/tests/unit/containers/Applications/__snapshots__/ApplicationDetailsPdf.test.tsx.snap
@@ -964,7 +964,7 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
                   Object {
                     "comments": "mollit eu esse",
                     "isEnergyProduct": false,
-                    "productAmount": 0,
+                    "productAmount": 50000000,
                     "productRowId": -60000000,
                     "productUnits": "in qui",
                     "requiresEmissionAllocation": false,
@@ -1008,7 +1008,7 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
                             Object {
                               "properties": Object {
                                 "productEmissions": Object {
-                                  "exclusiveMinimum": 0,
+                                  "minimum": 0,
                                   "title": "Emissions allocated to product",
                                   "type": "number",
                                 },
@@ -1027,6 +1027,7 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
                             Object {
                               "properties": Object {
                                 "productAmount": Object {
+                                  "minimum": 0,
                                   "title": "Annual Production Amount",
                                   "type": "number",
                                 },

diff --git a/app/tests/unit/containers/Forms/__snapshots__/ProductionFields.test.tsx.snap b/app/tests/unit/containers/Forms/__snapshots__/ProductionFields.test.tsx.snap
@@ -127,7 +127,7 @@ exports[`The ProductionFields Component with archived product should match the s
               Object {
                 "properties": Object {
                   "productEmissions": Object {
-                    "exclusiveMinimum": 0,
+                    "minimum": 0,
                     "title": "Emissions allocated to product",
                     "type": "number",
                   },
@@ -146,6 +146,7 @@ exports[`The ProductionFields Component with archived product should match the s
               Object {
                 "properties": Object {
                   "productAmount": Object {
+                    "minimum": 0,
                     "title": "Annual Production Amount",
                     "type": "number",
                   },
@@ -352,7 +353,7 @@ exports[`The ProductionFields Component with published product should match the
             Object {
               "properties": Object {
                 "productEmissions": Object {
-                  "exclusiveMinimum": 0,
+                  "minimum": 0,
                   "title": "Emissions allocated to product",
                   "type": "number",
                 },
@@ -371,6 +372,7 @@ exports[`The ProductionFields Component with published product should match the
             Object {
               "properties": Object {
                 "productAmount": Object {
+                  "minimum": 0,
                   "title": "Annual Production Amount",
                   "type": "number",
                 },

diff --git a/schema/data/prod/form_json/production.json b/schema/data/prod/form_json/production.json
@@ -41,7 +41,7 @@
                   "productEmissions": {
                     "title": "Emissions allocated to product",
                     "type": "number",
-                    "exclusiveMinimum": 0
+                    "minimum": 0
                   },
                   "requiresEmissionAllocation": {
                     "const": true
@@ -57,7 +57,8 @@
                 "requiresProductAmount": { "const": true },
                 "productAmount": {
                   "title": "Annual Production Amount",
-                  "type": "number"
+                  "type": "number",
+                  "minimum": 0
                 },
                 "productUnits": {
                   "title": "Units",