Skip to content

Commit

Permalink
feat(admin-form): remove fax number from admin form
Browse files Browse the repository at this point in the history
  • Loading branch information
@matthieu-foucault
matthieu-foucault committed Apr 29, 2020
1 parent a27be2b commit c6f1f4c
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 84 deletions.
3 changes: 0 additions & 3 deletions app/cypress/integration/application-form-validation.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ describe('When reviewing a submitted application as an analyst', () => {
cy.get('#root_operationalRepresentative_phone')
.clear()
.type('9009009001');
cy.get('#root_operationalRepresentative_fax')
.clear()
.type('6476478009');

// Operational rep mailing address
cy.get('#root_operationalRepresentative_mailingAddress_streetAddress')
Expand Down
1 change: 0 additions & 1 deletion app/server/schema.graphql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9265,7 +9265,6 @@ type OperatorContactDatum {
contactProvince: String
contactType: String
email: String
fax: String
firstName: String
lastName: String
positionTitle: String
Expand Down
12 changes: 0 additions & 12 deletions app/server/schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25605,18 +25605,6 @@
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "fax",
"description": null,
"args": [],
"type": {
"kind": "SCALAR",
"name": "String",
"ofType": null
},
"isDeprecated": false,
"deprecationReason": null
},
{
"name": "firstName",
"description": null,
Expand Down
50 changes: 11 additions & 39 deletions app/tests/integration/Forms/__snapshots__/Form.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="culpa"
value="in qui"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -469,7 +469,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="in qui"
value="est dolor"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -498,7 +498,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="mollit eu esse"
value="consequat Ut Duis"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -527,7 +527,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="email"
value="mzFgms@AfkpuAfkpuAfkp.ncf"
value="gszFg@puAfkpu.cfh"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -556,35 +556,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="tel"
value="consequat Ut Duis"
/>
<span
className="font-italic text-muted"
/>
</div>
<div
className="form-group field field-string form-group col-xl-6 col-lg-6 col-md-6 col-sm-12 col-12"
>
<label
className="form-label"
htmlFor="root_operationalRepresentative_fax"
>
Fax Number
</label>
<input
autoFocus={false}
className="form-control"
disabled={false}
id="root_operationalRepresentative_fax"
label="Fax Number"
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
placeholder=""
readOnly={false}
required={false}
type="tel"
value="est dolor"
value="culpa"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -631,7 +603,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="mollit eu esse"
value="est dolor"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -660,7 +632,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="culpa"
value="consequat Ut Duis"
/>
<span
className="font-italic text-muted"
Expand Down Expand Up @@ -689,7 +661,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
readOnly={false}
required={true}
type="text"
value="A1k4A1"
value="u5f3u5"
/>
<span
className="font-italic text-muted"
Expand All @@ -714,7 +686,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
onChange={[Function]}
onFocus={[Function]}
required={true}
value="New Brunswick"
value="Manitoba"
>
<option
value=""
Expand Down Expand Up @@ -1187,7 +1159,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
autoFocus={false}
checked={false}
disabled={false}
name="0.1"
name="0.5"
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
Expand All @@ -1210,7 +1182,7 @@ exports[`Form should match the snapshot with the administration form 1`] = `
autoFocus={false}
checked={true}
disabled={false}
name="0.1"
name="0.5"
onBlur={[Function]}
onChange={[Function]}
onFocus={[Function]}
Expand Down
21 changes: 5 additions & 16 deletions app/tests/unit/containers/Applications/__snapshots__/ApplicationDetailsPdf.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -213,18 +213,17 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
"naics": "4512",
},
"operationalRepresentative": Object {
"email": "gszFg@puAfkpu.cfh",
"fax": "mollit eu esse",
"firstName": "in qui",
"lastName": "est dolor",
"email": "Fmsy@fkpuAfkpuAfkpuAfk.kn",
"firstName": "mollit eu esse",
"lastName": "consequat Ut Duis",
"mailingAddress": Object {
"city": "in qui",
"postalCode": "f2p5f2",
"province": "Northwest Territories",
"streetAddress": "consequat Ut Duis",
},
"phone": "culpa",
"position": "consequat Ut Duis",
"phone": "est dolor",
"position": "in qui",
},
"operator": Object {
"bcCorporateRegistryNumber": "K4512345",
Expand Down Expand Up @@ -394,10 +393,6 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
"title": "Email Address",
"type": "string",
},
"fax": Object {
"title": "Fax Number",
"type": "string",
},
"firstName": Object {
"title": "First Name",
"type": "string",
Expand Down Expand Up @@ -511,11 +506,6 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
],
},
"operationalRepresentative": Object {
"fax": Object {
"ui:options": Object {
"inputType": "tel",
},
},
"mailingAddress": Object {
"postalCode": Object {
"ui:placeholder": "ex: A1A 1A1",
Expand All @@ -538,7 +528,6 @@ exports[`ApplicationDetailsPdf should render application pdf donwload link 1`] =
"position",
"email",
"phone",
"fax",
"mailingAddress",
],
},
Expand Down
10 changes: 0 additions & 10 deletions schema/data/prod/form_json/administration.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,6 @@
"firstName"
],
"properties": {
"fax": {
"type": "string",
"title": "Fax Number"
},
"email": {
"type": "string",
"title": "Email Address",
Expand Down Expand Up @@ -295,11 +291,6 @@
"facility"
],
"operationalRepresentative": {
"fax": {
"ui:options": {
"inputType": "tel"
}
},
"phone": {
"ui:options": {
"inputType": "tel"
Expand All @@ -311,7 +302,6 @@
"position",
"email",
"phone",
"fax",
"mailingAddress"
],
"mailingAddress": {
Expand Down
2 changes: 0 additions & 2 deletions schema/deploy/swrs_functions/get_swrs_operator_contact_data.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ begin;
contact_type varchar(1000),
email varchar(1000),
telephone varchar(1000),
fax varchar(1000),
contact_mailing_address varchar(1000),
contact_city varchar(1000),
contact_province varchar(1000),
Expand Down Expand Up @@ -53,7 +52,6 @@ begin;
_contact.contact_type,
_contact.email_address,
_contact.telephone_number,
_contact.fax_number,
cast(
concat(
'unit ' || _contact_add.mailing_address_unit_number || ', ',
Expand Down
1 change: 0 additions & 1 deletion schema/deploy/swrs_functions/init_application_administration_form_result.sql
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ begin
'position', contact_data.position_title,
'email', contact_data.email,
'phone', contact_data.telephone,
'fax', contact_data.fax,
'mailingAddress', jsonb_build_object(
'streetAddress', contact_data.contact_mailing_address,
'city', contact_data.contact_city,
Expand Down

0 comments on commit c6f1f4c

Please sign in to comment.