fix: replace quinary expression with a variable re-assignment

bcgov · Nov 30, 2020 · cbac6f8 · cbac6f8
1 parent 3f57288
commit cbac6f8
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/app/containers/Admin/ReportingYear/ReportingYearTable.tsx b/app/containers/Admin/ReportingYear/ReportingYearTable.tsx
@@ -24,12 +24,9 @@ function getMostRecentlyClosedYear(query) {
     .sort((yearA, yearB) => {
       const yearACloseTime = defaultMoment(yearA.node.applicationCloseTime);
       const yearBCloseTime = defaultMoment(yearB.node.applicationCloseTime);
-
-      return yearACloseTime.isBefore(yearBCloseTime)
-        ? 1
-        : yearBCloseTime.isBefore(yearACloseTime)
-        ? -1
-        : 0;
+      let sortOrder = yearACloseTime === yearBCloseTime ? 0 : 1;
+      if (yearBCloseTime.isBefore(yearACloseTime)) sortOrder *= -1;
+      return sortOrder;
     });
   // Can edit only the most recently closed reporting period
   // (unless the next application window has already opened - prevents overlap):