Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP-144: Modified default for COOKIE_DOMAIN #51

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

BradyMitch
Copy link
Collaborator

@BradyMitch BradyMitch commented Mar 28, 2024

🎯 Summary

MVP-144

Sets the default value for COOKIE_DOMAIN to localhost if FRONTEND_URL includes localhost, otherwise it sets to .gov.bc.ca

  • Updated Wiki Env vars

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • I have consulted with the team if introducing a new dependency.
  • My changes generate no new warnings.

@BradyMitch BradyMitch merged commit c7c6a1d into main Apr 2, 2024
@BradyMitch BradyMitch deleted the mvp-144-fix-cookie-issue branch April 2, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants