Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP-224: Fixed refresh expiry issue #70

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

BradyMitch
Copy link
Collaborator

@BradyMitch BradyMitch commented Apr 25, 2024

🎯 Summary

MVP-224

Updated to alpha6.

Issue was caused by the login redirect canceling the setTimeout for the refresh expiry function.

Test by running npm run build in this projects root directory, then running npm run rebuild:override in the citz-imb-common-code repo.

You can set refreshExpiresInOffset prop on SSOProvider to -1770 to force the pop up to show after about a 30 seconds.

Also ensure you have also cloned the sso-css-api and sso-express repos and run npm run build in those projects for the override to work.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • I have consulted with the team if introducing a new dependency.
  • My changes generate no new warnings.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh expire popup works as expected
no issues detected

@BradyMitch BradyMitch merged commit fa0ca75 into main Apr 26, 2024
@BradyMitch BradyMitch deleted the mvp-224-refresh-expiry-issue branch April 26, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants