build: FORMS-1768 update happy-dom to fix vulnerability #1612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalterMoar
commented
Feb 20, 2025
| // This needs to be implemented | ||
| // TODO: This needs to be implemented |
There was a problem hiding this comment.
Added a TODO here to highlight the technical debt in Sonar.
WalterMoar
commented
Feb 20, 2025
Comment on lines
-117
to
-119
| const mockInputElement = document.createElement('input'); | ||
| mockInputElement.type = 'file'; | ||
| const file = await readFile(mockInputElement); |
There was a problem hiding this comment.
This was failing because readFile doesn't take a DOM element as input. Not sure how it ever passed.
|
Release fe252f1 deployed at https://chefs-dev.apps.silver.devops.gov.bc.ca/pr-1612 |
WalterMoar
requested review from
usingtechnology,
abhilash-aot,
nimya-aot,
RyanBirtch-aot and
revanth-banala
WalterMoar
commented
Feb 21, 2025
Comment on lines
+500
to
+502
| windowOpenSpy.mockReset(); | ||
| appendChildSpy.mockReset(); | ||
| addNotificationSpy.mockReset(); |
There was a problem hiding this comment.
I think something in the mount was calling these spies. Since we're not testing the mount, they should be cleared afterwards (tests were failing)
We're nine major versions behind on this package so it is going to break a few tests
WalterMoar
force-pushed
the
build/1768-happy-dom-vuln
branch
from
9d99661 to
4f9d12d
Compare
|
WalterMoar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GitHub Dependabot process has created an alert for the
happy-domdependency. To satisfy the requirements outlined in the Security Threat and Risk Assessment's (STRA) Statement of Acceptable Risks (SoAR), this vulnerability must be handled by updating the package version (or mitigated in some other way, if updating the package is not possible).https://github.com/bcgov/common-hosted-form-service/security/dependabot/211
Type of Change
build (change in build system or dependencies)
Checklist
Further comments
Note: also fixed a warning that the test config file format is using a deprecated element structure.