Prevent json files from being pre-emptively parsed when uploading as file #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file We introduce the express-unless library in order to pattern match against the two endpoints createObject and updateObject and ensure that the express.json middleware skips execution on those two endpoints. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
added
bug
Coverage Report
|
|
Code Climate has analyzed commit affe160 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.5% (0.0% change). View more on Code Climate. |
wilwong89
approved these changes
Aug 18, 2023
norrisng-bc
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We introduce the express-unless library in order to pattern match against the two endpoints
createObjectandupdateObjectand ensure that the express.json middleware skips execution on those two endpoints.SHOWCASE-3322
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments