Standardize sync calls to return modified flag and subject in object #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modifies general function signatures to not be object option shaped as there are parameters that must be supplied in order to function. This also adds some missing etrx wrappers to existing service calls so that they can support transaction streaming. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
TimCsaky
approved these changes
Aug 24, 2023
|
Merged with only one review because we need to start testing with this and can fix bugs in subsequent PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also modifies general function signatures to not be object option shaped as there are parameters that must be supplied in order to function. This also adds some missing etrx wrappers to existing service calls so that they can support transaction streaming.
SHOWCASE-3313
Types of changes
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments
Unit tests are known to be failing - this will be addressed in subsequent PR.