Full mode #201
Merged
Full mode #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
TimCsaky
force-pushed
the
full-mode
branch
2 times, most recently
from
9daeeb6 to
303a2ac
Compare
Objects, Versions and Tags must always be updated no matter what, so we modified the syncJob logic so that it determines whether it has to update metadata as most of the time those values are not modifiable unless the bucket is unversioned. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Coverage Report
|
jujaga
approved these changes
Aug 30, 2023
wilwong89
approved these changes
Aug 30, 2023
norrisng-bc
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fullmode from the sync feature. (ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3334)logic still exists in controller and service if implemented at a later date
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments