Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test Sync Service #204

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Unit Test Sync Service #204

merged 4 commits into from
Sep 5, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Sep 2, 2023 •
edited
Loading

Description

This PR implements unit test coverage for the sync service, as well as addressing various inconsistency bugs.

  • d567284 Implement unit tests for sync service
  • e79eb35 Ensure TagSet defaults to an empty array instead of undefined
  • af39350 Bugfix isAtPath to accept identical prefix/path values
  • 6855c10 Routine Dockerfile base image version bump

SHOWCASE-3313

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

jujaga added 3 commits August 31, 2023 16:25
@jujaga
Routine Dockerfile base image version bump
6855c10 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Bugfix isAtPath to accept identical prefix/path values
af39350 
The previous fix checking for length being less than 2 was not accurate
because it was letting paths with just a trailing slash to pass through.
We roll it back to checking if the length is exactly 1 in difference, and
also do an earlier check for prefix and path being identical in order to
better handle the exception cases.

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga
Ensure TagSet defaults to an empty array instead of undefined
e79eb35 
There are various places where the TagSet is assumed to always be an array.
However, Dell ECS may return situations where the TagSet is outright
undefined instead of yielding an empty array. We compensate for this to
prevent any undesired undefined parsing issues.

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga jujaga added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 2, 2023
@jujaga jujaga requested a review from wilwong89 September 2, 2023 00:13
@jujaga jujaga self-assigned this Sep 2, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

Coverage Report

Totals Coverage
Statements: 52.5% ( 2455 / 4676 )
Methods: 42.54% ( 268 / 630 )
Lines: 58.66% ( 1487 / 2535 )
Branches: 46.33% ( 700 / 1511 )

@jujaga jujaga mentioned this pull request Sep 2, 2023
Closed
4 tasks
@jujaga
Implement unit tests for sync service
d567284 
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@TimCsaky TimCsaky merged commit 48255e4 into release/sync Sep 5, 2023
@jujaga jujaga deleted the test/sync branch September 5, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norrisng-bc norrisng-bc norrisng-bc approved these changes

@TimCsaky TimCsaky TimCsaky approved these changes

@wilwong89 wilwong89 Awaiting requested review from wilwong89

Assignees

@jujaga jujaga

Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jujaga @TimCsaky @norrisng-bc