Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isLatest #206

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Update isLatest #206

merged 1 commit into from
Sep 6, 2023

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented Sep 5, 2023 •
edited
Loading

Description

  • ensure version.isLatest data is updated properly in db
  • moved some of that process to function removeDuplicateLatest()
  • updated k6 createObject script to fix randomization of filename and tags

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@github-actions
Copy link

github-actions bot commented Sep 5, 2023 •
edited
Loading

Coverage Report

Totals Coverage
Statements: 52.35% ( 2455 / 4690 )
Methods: 42.54% ( 268 / 630 )
Lines: 58.52% ( 1487 / 2541 )
Branches: 46.08% ( 700 / 1519 )

@TimCsaky
Update version isLatest
30d140b 
remove duplicate 'latest' versions
set version.isLatest from object controllers
@TimCsaky TimCsaky changed the title Update isLatest for createObject and sync Update isLatest Sep 6, 2023
@norrisng-bc norrisng-bc closed this Sep 6, 2023
@norrisng-bc norrisng-bc reopened this Sep 6, 2023
@norrisng-bc norrisng-bc merged commit ed3494a into release/sync Sep 6, 2023
@jujaga jujaga deleted the syncLatest branch September 6, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norrisng-bc norrisng-bc norrisng-bc approved these changes

@jujaga jujaga jujaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimCsaky @jujaga @norrisng-bc