Remove Metadata length constraint and update dependencies #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
The S3 spec only limits user metadata total header length to 2KB in size. It does not limit key nor value lengths to 255, so this PR lifts that constraint across the schema, model, and validation layers. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
added
bug
jujaga
requested review from
norrisng-bc,
TimCsaky and
jatindersingh93
as code owners
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 238b708 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 64.7% (0.0% change). View more on Code Climate. |
Coverage Report
|
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
norrisng-bc
approved these changes
Oct 12, 2023
TimCsaky
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SHOWCASE-3375
Types of changes
Bug fix (non-breaking change which fixes an issue)
Documentation (non-breaking change with enhancements to documentation)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments