Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for certain sync features #228

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Add tests for certain sync features #228

merged 5 commits into from
Nov 24, 2023

Conversation

wilwong89
Copy link
Contributor

Description

Tests written for version.spec.js, utils.spec.js and sync.spec.js
Cleaned up some linting warnings for all other files

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Nov 20, 2023

Code Climate has analyzed commit 479b849 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 65.6% (0.8% change).

View more on Code Climate.

Copy link

github-actions bot commented Nov 20, 2023

Coverage Report

Totals Coverage
Statements: 59% ( 2703 / 4581 )
Methods: 49.04% ( 307 / 626 )
Lines: 65.6% ( 1621 / 2471 )
Branches: 52.22% ( 775 / 1484 )

app/tests/unit/services/version.spec.js Outdated Show resolved Hide resolved
app/tests/unit/services/sync.spec.js Outdated Show resolved Hide resolved
Tests written for version.spec.js, utils.spec.js and sync.spec.js
Cleaned up some linting warnings for all other files
@wilwong89 wilwong89 force-pushed the tests/sync-unit-tests branch from 6f3dd50 to 130705c Compare November 23, 2023 20:19
Copy link
Member

@jujaga jujaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor optional style notes.

app/tests/unit/services/version.spec.js Outdated Show resolved Hide resolved
app/tests/unit/services/version.spec.js Outdated Show resolved Hide resolved
@jujaga jujaga merged commit a07a0c8 into master Nov 24, 2023
16 checks passed
@jujaga jujaga deleted the tests/sync-unit-tests branch November 24, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants