Add support for children bucket creation #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujaga
added
documentation
jujaga
requested review from
norrisng-bc,
TimCsaky,
jatindersingh93,
wilwong89 and
kyle1morel
as code owners
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 496d385 and detected 10 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 62.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.7% (0.1% change). View more on Code Climate. |
Coverage Report
|
TimCsaky
approved these changes
Dec 11, 2023
jujaga
force-pushed
the
feature/createBucketChild
branch
from
83f2ace to
2b1861e
Compare
| @@ -703,7 +741,8 @@ const controller = { | |||
|
|
|||
| // Download via service proxy | |||
| if (req.query.download && req.query.download === DownloadMode.PROXY) { | |||
| // TODO: Consider if we need a HEAD operation first before doing the actual read on large files for pre-flight caching behavior? | |||
| // TODO: Consider if we need a HEAD operation first before doing the actual read on large files | |||
wilwong89
approved these changes
Dec 12, 2023
jatindersingh93
approved these changes
Dec 12, 2023
TimCsaky
reviewed
Dec 12, 2023
There was a problem hiding this comment.
when i call the endpoint with body:
{"bucketName":"abc"}i get the 409 conflict response:
{"type":"https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/409","title":"Conflict","status":409,"bucketId":"5078dd24-c6a6-43bd-9205-42393d9c7eb4","detail":"Requested bucket already exists","instance":"/api/v1/bucket/5078dd24-c6a6-43bd-9205-42393d9c7eb4/child","key":"coms/tim"}maybe you just need to put 'required()` on the joi schema for subKey
Also ensure that Joi.trim() is properly enforced with Joi.strict() Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
feature/createBucketChild
branch
from
2b1861e to
496d385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on implementing the ability to create children buckets without necessarily knowing the raw S3 bucket credentials.
SHOWCASE-3399
Types of changes
New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)
Checklist
Further comments
As this PR also does a complete codebase update to remove the max-len lint warnings, there are many inconsequential differences in the changelog. The core changes of this PR can be found in the following files:
app/src/controllers/bucket.jsapp/src/docs/v1.api-spec.yamlapp/src/routes/v1/bucket.jsapp/src/validators/bucket.jsapp/tests/unit/controllers/bucket.spec.jsapp/tests/unit/validators/bucket.spec.js