Bugfix synchronization collisions with database when the object entry already exists #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujaga
requested review from
norrisng-bc,
TimCsaky,
jatindersingh93,
wilwong89 and
kyle1morel
as code owners
|
Code Climate has analyzed commit 3576cab and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 66.3% (0.5% change). View more on Code Climate. |
Coverage Report
|
Signed-off-by: Jeremy Ho <jujaga@gmail.com>
The searchObjects service call had a structural change that was not propagating correctly to the synchronization methods. This commit fixes that by ensuring that the values are extracted out correctly from the new structure. Also improved test branch coverage and JSDocs. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
…licy Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
bugfix/searchObject
branch
from
6417271 to
3576cab
Compare
kyle1morel
approved these changes
Jan 12, 2024
jatindersingh93
approved these changes
Jan 12, 2024
TimCsaky
approved these changes
Jan 12, 2024
| key: 'key', | ||
| userId: SYSTEM_USER, | ||
| permissions: false | ||
| }; |
There was a problem hiding this comment.
shouldnt the pagination query params be in here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Synchronization was attempting to perform an insertion operation when the object already exists and collides with the database. It was not going down the right branch of sync code.
Synchronization does not work at this time for objects that already exist in COMS, and will impact clients' ability to retrieve up to date statuses of their S3 buckets.
SHOWCASE-3498
SHOWCASE-3503
Types of changes
Bug fix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments