Modify getObject CORP header to use cross-origin policy #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are use cases where COMS is being used as a way to directly reference and embed content into a 3rd-party webpage. The default helmet CORP policy of same-origin was too restrictive for this specific endpoint. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
requested review from
norrisng-bc,
TimCsaky,
jatindersingh93,
wilwong89 and
kyle1morel
as code owners
Coverage Report
|
|
Code Climate has analyzed commit dc254b9 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 66.3% (0.0% change). View more on Code Climate. |
kyle1morel
approved these changes
Jan 15, 2024
TimCsaky
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are use cases where COMS is being used as a way to directly reference and embed content into a 3rd-party webpage. The default helmet CORP policy of same-origin was too restrictive for this specific endpoint.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3509
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments