-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate lastSyncedDate on object create/update when syncing object #247
Conversation
Code Climate has analyzed commit 7702747 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 66.7% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lastSyncedDate
column should only be populated and modified via a /sync operation (stemming from syncBucket or syncObject for example). For standard object manipulations such as objectCreate and objectUpdate, whatever the lastSyncedDate value is must be preserved and not manipulated, as the column is meant to precisely report back when an object last had an explicit synchronization operation applied. Object create and update are not able to safely assert that a complete synchronization has taken place as that is not what those endpoints are designed to do.
912db73
to
95c68f5
Compare
8351586
to
eae3d6b
Compare
eae3d6b
to
aad08a0
Compare
33696c9
to
f123815
Compare
In an earlier commit, lastSyncedDate would be updated/populated on object update/create (even when not syncing) - this is incorrect behaviour Also: * Have comsObject update within the syncObject transaction (`trx`) * Update tests: sync service, object service
f123815
to
7702747
Compare
Description
object.lastSyncedDate
is now populated on object create/update (but only when this happens during an object sync operation).Edit, Feb 27: only populate when syncing object
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3506
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
N/A