Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full object permissions in object search #248

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Return full object permissions in object search #248

merged 1 commit into from
Feb 13, 2024

Conversation

TimCsaky
Copy link
Contributor

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3539
if user does objectSearch with permissions=true,
return all permission details for each object

note: the objectSearch query (specifically the hasPermission() modifier has become unwiedly and not written efficiently.
The changes in this pr accommodate for that.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Documentation (non-breaking change with enhancements to documentation)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codeclimate bot commented Feb 12, 2024

Code Climate has analyzed commit caed857 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 66.5% (0.0% change).

View more on Code Climate.

Copy link

github-actions bot commented Feb 12, 2024

Coverage Report

Totals Coverage
Statements: 59.81% ( 2811 / 4700 )
Methods: 50.47% ( 321 / 636 )
Lines: 66.54% ( 1690 / 2540 )
Branches: 52.49% ( 800 / 1524 )

if user does objectSearch with permissions=true,
return all permission details for each object
@TimCsaky TimCsaky merged commit 427d162 into master Feb 13, 2024
16 checks passed
@jujaga jujaga deleted the ob-perm branch February 21, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants