Implement lastSyncRequestedDate tracking support #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jujaga
added
documentation
jujaga
requested review from
norrisng-bc,
TimCsaky,
jatindersingh93,
wilwong89 and
kyle1morel
as code owners
Coverage Report
|
|
Code Climate has analyzed commit 8e7070d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 67.1% (0.3% change). View more on Code Climate. |
norrisng-bc
reviewed
Feb 29, 2024
Also fixes a few long standing skipped unit tests. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
force-pushed
the
feature/lastSyncRequestedDate
branch
from
18485f1 to
8e7070d
Compare
jatindersingh93
approved these changes
Feb 29, 2024
TimCsaky
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR focuses on ensuring that the lastSyncRequestedDate is logged whenever a successful syncBucket or syncDefault request occurs. Also fixes a few long standing skipped unit tests.
SHOWCASE-3507
Types of changes
New feature (non-breaking change which adds functionality)
Documentation (non-breaking change with enhancements to documentation)
Checklist
Further comments