Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select - refactor icons #441

Closed
mkernohanbc opened this issue Aug 8, 2024 · 0 comments · Fixed by #450
Closed

Select - refactor icons #441

mkernohanbc opened this issue Aug 8, 2024 · 0 comments · Fixed by #450
Assignees
@mkernohanbc
Labels
enhancement New feature or request
Milestone
Components v0.2.0

Comments

@mkernohanbc
Copy link
Contributor

Following on from the changes in #440 and elsewhere to how we're implementing icons, we need to do some refactoring of the Select component to:

  • use the SvgExclamationIcon component instead of instantiating iconError within the component
  • componentise the ChevronUp and ChevronDown functions
@mkernohanbc mkernohanbc self-assigned this Aug 8, 2024
@mkernohanbc mkernohanbc added the enhancement New feature or request label Aug 8, 2024
@mkernohanbc mkernohanbc added this to the Components v0.2.0 milestone Aug 8, 2024
@mkernohanbc mkernohanbc linked a pull request Aug 13, 2024 that will close this issue
Select - refactor icons #450
Merged
@ty2k ty2k closed this as completed in #450 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkernohanbc mkernohanbc

Labels
enhancement New feature or request
Projects
None yet
Milestone
Components v0.2.0
Development

Successfully merging a pull request may close this issue.

Select - refactor icons bcgov/design-system
1 participant
@mkernohanbc