-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select - refactor icons #450
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ty2k do we need the React import on line 1, or is that legacy stuff?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need it in this case, because we're using it for our TypeScript definitions, like iconLeft?: React.ReactElement;
.
Couple things with this one: In our component files, we don't want be to using the Vite Secondly, we should avoid extraneous |
This change updates the Select component to use componentised versions of icons, rather than instantiating icons as functions within the component itself.
iconError
with theSvgExclamationIcon
component, and adds some additional CSS to style itSvgChevronUpIcon
andSvgChevronDownIcon
)ChevronUp
andChevronDown
functions with the new components