Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Bug - Staff Transfer Due to Sale/Gift - Issue when changing from SO to Tenants in Common #17754

Closed
tlebedovich opened this issue Sep 15, 2023 · 7 comments
Assignees
Labels
Assets bug Something isn't working UX Assurance

Comments

@tlebedovich
Copy link

tlebedovich commented Sep 15, 2023

This bug is most likely related to bug #18197

Issue when changing from SO to Tenants in Common (in TEST/DEV):

Bug : Previous Owner Group

See Quicktime video to see what I did to create the bug:

Private Zenhub Video

Steps I took:
STARTED a Transfer due to sale/gift with a sole owner
THEN added new owner to a group (group 2)
AND the original owner got automatically got moved into group 1 and interest set as N/A (as it should)
THEN I added new owner to Group 1 and in the process updated the N/A interest to 1/2 while adding this owner
NOW group 1 now contains the original existing owner plus a newly added owner.
WHEN I delete the original owner, they are automatically moved to their own "previous owners group" (as should happen)
THEN I deleted the new owner that was left in Group 1,
AND then deleted that empty Group 1
BUT instead of the empty Group 1 being removed completely from the table (since it no longer contained any existing owners) when I deleted the empty Group 1, it showed also as a "previous owner group" with a broken undo button (the bug)

Note: It feels like once a new owner is added to a group with an existing owner, even when that existing owner gets removed from that group, the group still acts like its an existing group instead of a new group.

Private Zenhub Image

@tlebedovich tlebedovich added Assets bug Something isn't working UX Assurance labels Sep 15, 2023
@tlebedovich
Copy link
Author

@mstanton1 - another staff sale/gift bug to add

@tlebedovich tlebedovich changed the title UI - Bug Staff Transfer Due to Sale/Gift - Bug when changing from SO/JT to Tenants in Common UI - Bug Staff Transfer Due to Sale/Gift - previous owner group appearing instead of removing group from the table Sep 15, 2023
@tlebedovich tlebedovich changed the title UI - Bug Staff Transfer Due to Sale/Gift - previous owner group appearing instead of removing group from the table UI - Bug Staff Transfer Due to Sale/Gift - Issues when changing from SO to Tenants in Common Sep 15, 2023
@tlebedovich
Copy link
Author

Found some further complications so will review this ticket again with fresh eyes on Monday. Will ping when its ready.

@tlebedovich tlebedovich changed the title UI - Bug Staff Transfer Due to Sale/Gift - Issues when changing from SO to Tenants in Common UI - Bug - Staff Transfer Due to Sale/Gift - Issue when changing from SO to Tenants in Common Sep 20, 2023
@tlebedovich
Copy link
Author

ok @mstanton1 - this staff sale/gift transfer bug ticket is now ready to go

@mstanton1
Copy link
Collaborator

@cameron-eyds
Copy link
Collaborator

Moving into staging for my own tracking until commit is ready, but have fixed locally.
Will bundle fix with ticket 18197.

@tlebedovich
Copy link
Author

@cameron-eyds great work. moving to RFQA.
@chdivyareddy - I only tested with Staff, please also check for Qualified Supplier thanks.

@chdivyareddy
Copy link
Collaborator

Verified in DEV for Staff & QS flows.

Staff:
image.png

QS:
image.png

@PCC199 PCC199 closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assets bug Something isn't working UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants