Bug - Transfer Due to Sale/Gift - Issue when changing from SO to TIC

[tlebedovich]

This bug is most likely also related to bug #17754

---

on DEV site:
The order you do this is important:

IF you open an MHR with a Sole Owner
THEN add a new owner to group 2 to make this a tenants in Common
THEN update the interest for Group 1 which has the original owner (because Interest is red N/A)
THEN add another new owner to Group 1 (the group with the original owner)
THEN delete the original owner from Group 1 (which moves into a previous owner group as it should)

The Issue that appears: Now that Group 1 no longer has any original owners and just has a new owner in it, the badge for Group 1 should say ADDED and the Button should be Delete Group (just like in Group 2)

Note: It feels like once a new owner is added to a group with an existing owner, even when that existing owner gets removed from that group, the group still acts like its an existing group instead of a new group.

---

screenshots (in order)

1. added new owner to group 2:

2. updated the interest for group 1:

3. added a another new owner to group 1:
   

4. deleted the original owner from group 1:
   

[dimak1]

You can re-assign this to yourself @cameron-eyds

[tlebedovich]

@cameron-eyds looks good to me. @chdivyareddy I tested logged in as staff, please also test logged in as a Qualified Supplier. Thanks. Moving to RFQA

[chdivyareddy]

Verified in DEV for both staff & QS flow.

Staff:

QS:

[chdivyareddy]

@cameron-eyds , I'm now not seeing the 'Added' badge beside the Group1 (this change was made while back before the Vue3 upgrade I believe). Please take a look, thanks!!

Expected:

[cameron-eyds]

Hmm If this was verified in DEV, Dec 12, that would have been the Vue3 build.
I will have a look!

[cameron-eyds]

I followed the steps in the ticket in DEV and saw the expected result:

Confirmed in TEST as well.

@chdivyareddy Perhaps there was a different order of operations to reproduce, outside the steps Tracey had outlined above?

*Edit: I found a scenario, where if you don't edit the group Interest values and add a new owner to the group, which requires interest values and delete the original owner, it won't show the added.

That being said, it was not the exact steps outlined in the ticket, but potentially we still want it to say added?
I'm not 100% sure if it's the same requirement but should we add it in for this scenario as well?

[chdivyareddy]

@cameron-eyds , Yes you are right! 'Added' badge doesn't gets added when the interest value is not edited before adding the owner to the existing group. I think we still would like to display the 'Added' badge in this scenario as well.
cc @tlebedovich Can you please take a look, thanks!!

[tlebedovich]

having a look now...

[tlebedovich]

@cameron-eyds @chdivyareddy - I am in agreement. Since Group 1 no longer contains any of the original existing owners (original SO was deleted), Group 1 would be considered a net new group, so the ADDED badge would appear in this scenario as well.

[cameron-eyds]

@tlebedovich @chdivyareddy Thank you both for checking/confirming! Will update this

[cameron-eyds]

@chdivyareddy Have updated as per discussions above, ready for another look!

[chdivyareddy]

Verified in DEV for both scenarios.