Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Business Removal in SJT Transfer #1693

Merged

Conversation

cameron-eyds
Copy link
Collaborator

Issue #: /bcgov/entity#18066
/bcgov/entity#18656
/bcgov/entity#18197

Description of changes:

  • New component for handling Business Removal in Transfers to Surviving Joint Tenants.
  • Updated labels, messaging and validations to handle 'Historical' business removals alongside 'Deceased' owner removals in Transfer to SJT's.
  • Minor Label fix edge case scenario (ie, ADDED/CHANGED badge when group has removed all original owners) see 18197
  • Minor property updates and handling to submit Transfer SJT's when a business is present.
  • Misc styling fixes to correct the spacing of Death Certificates and the new component in the Home Owners table during a transfer.
  • Some pics for context, for groupless and grouped scenarios:

Screenshot 2024-01-17 at 1 01 10 PM

Screenshot 2024-01-17 at 1 01 24 PM

Screenshot 2024-01-17 at 1 03 23 PM

Screenshot 2024-01-17 at 1 09 47 PM

Screenshot 2024-01-17 at 1 10 05 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds cameron-eyds self-assigned this Jan 17, 2024
@cameron-eyds
Copy link
Collaborator Author

/gcbrun

Comment on lines -122 to -127
const deathCertificateNumberRules = computed(
(): Array<()=>string|boolean> => customRules(
maxLength(20),
required('Enter Death Certificate Registration Number')
)
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate definition, was already defined in localState as a computed value

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-1693-80g5x92w.web.app

@cameron-eyds
Copy link
Collaborator Author

cameron-eyds commented Jan 17, 2024

@doug-lovett I completed a few of these filings and just wanted to confirm something about the output content.
Are they supposed to display the removed owners or typically just the new/current set of owners?

The outputs looked good otherwise!

@cameron-eyds for transfers the output content has not changed in quite some time - just the new/current set of owners.

  • Sounds good sir, thank you verifying!

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

Copy link
Collaborator

@dimak1 dimak1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@cameron-eyds cameron-eyds merged commit 860575d into bcgov:main Jan 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants