-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Business Removal in SJT Transfer #1693
Support for Business Removal in SJT Transfer #1693
Conversation
/gcbrun |
const deathCertificateNumberRules = computed( | ||
(): Array<()=>string|boolean> => customRules( | ||
maxLength(20), | ||
required('Enter Death Certificate Registration Number') | ||
) | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate definition, was already defined in localState as a computed value
Temporary Url for review: https://bcregistry-assets-dev--pr-1693-80g5x92w.web.app |
@doug-lovett I completed a few of these filings and just wanted to confirm something about the output content. The outputs looked good otherwise! @cameron-eyds for transfers the output content has not changed in quite some time - just the new/current set of owners.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Issue #: /bcgov/entity#18066
/bcgov/entity#18656
/bcgov/entity#18197
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).