Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - No Bill of Sale Transfers (Staff only) #18220

Closed
5 tasks done
mstanton1 opened this issue Oct 17, 2023 · 20 comments
Closed
5 tasks done

UI - No Bill of Sale Transfers (Staff only) #18220

mstanton1 opened this issue Oct 17, 2023 · 20 comments

Comments

@mstanton1
Copy link
Collaborator

mstanton1 commented Oct 17, 2023

Misc Transfer Types without Bill of Sale:

  • Do not display Transfer Details Consideration Value and Date
  • Update field validations
  • Do not show Bill of Sale yellow alert bar
  • Confirm completion text updates
  • Remove the rule forcing removal of all execs/admins/trustees if one is removed (within a group)

(ABAN) = Transfer Due to Abandonment and Sale
(BANK) = Transfer Due to Bankruptcy
(COU) = Transfer Due to Court Order
(FORE) =Transfer Due to Foreclosure Order
(GENT) = Transfer Due to General Transmission
(TRANS_LAND_TITLE) = Transfer Due to Land Title
(REIV) =Transfer Due to Repossession – Involuntary
(REPV) = Transfer Due to Repossession – Voluntary
(SZL) =Transfer Due to Seizure under Land Act
(TAXS) = Transfer Due to Tax Sale
(VEST) = Transfer Due to Vesting Order

@PCC199
Copy link
Collaborator

PCC199 commented Apr 11, 2024

@dimak1 dimak1 assigned dimak1 and unassigned dimak1 Apr 22, 2024
@dimak1
Copy link
Collaborator

dimak1 commented Apr 23, 2024

@LizGovier

  1. The Figma design for Misc Transfers shows Declared Value field, but the first bullet in description says otherwise?
    Edit: Maybe the first bullet is supposed to say Consideration and not Declared Value?
  2. The Confirm Completion copy has some discrepancies. In Figma it is different from existing copy in Bill Sale Transfers, and it is not being called out as an update for Misc Transfers. Please see my comments in Figma.

@LizGovier
Copy link
Collaborator

LizGovier commented Apr 23, 2024

Hey @dimak1 ,

I didn't realize that the confirm completion text had been slightly adjusted. I've left my notes in figma for you to update all text that is in the current mock up. Let me know if you'd like add a bullet at the top and adjust the estimate or create a sepearate ticket.

@dimak1
Copy link
Collaborator

dimak1 commented Apr 24, 2024

@saragunnarsson
Copy link
Collaborator

saragunnarsson commented Apr 26, 2024

Thanks @dimak1 ! Sorry for taking so long to get to this. Just 2 things listed below. Everything else looks great!

  • Remove space (fix alignment)

image.png

  • Remove references to bill of sale and consideration on review and confirm screen

image.png

@dimak1
Copy link
Collaborator

dimak1 commented Apr 26, 2024

Ready for QA in DEV.

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented Apr 30, 2024

Hey @dimak1 , just noticed that for the No Bill of Sale transfers, when the transfer of ownership is Tenants in Common and one of the No Bill of Sale transfers is selected, then the 'Edit group details/delete group' buttons is disabled. Can you please take a look, thanks!!

MHR 108328 in DEV

image.png

Expected:
image.png

Also, the other thing noted was when a new group is added with an owner, the interest value 'Amount owned by this group' field should be empty, currently it is auto-filled.

image.png

@dimak1
Copy link
Collaborator

dimak1 commented Apr 30, 2024

@chdivyareddy thanks, I will take a look.

@dimak1
Copy link
Collaborator

dimak1 commented May 2, 2024

Hi @chdivyareddy, I'm almost done with the updates. Just one more question: could you please point me to the requirement that the fractional ownership fields should be cleared when selecting a New Group? (the figma link is blocked for the new group ticket).

@dimak1
Copy link
Collaborator

dimak1 commented May 2, 2024

Hi @LizGovier and @saragunnarsson, we need your help clarifying one of the requirements for the Fractional Ownership (screenshot above by Divya).

  • Do we prefill the Interest values in the Amount Owned & Total Available fields? Right now, it is prefilled when existing and new groups are selected from the dropdown.
  • Could you please check your latest figma comps, and confirm it? For existing and new groups.
    Thank you! cc: @chdivyareddy

@saragunnarsson
Copy link
Collaborator

saragunnarsson commented May 2, 2024

@dimak1 @chdivyareddy The only reference I can find is the below, which seems to imply that when registering a group we should autofill the value for subsequent groups, but if the group is edited we should not change the value for the rest of the groups. Here's a link to the figma I'm looking at - Lets keep it as it is in order to move the ticket forward, but lets get Liz to confirm when she gets back (if we need to update at that point we can create a ticket for it).

image.png

@dimak1
Copy link
Collaborator

dimak1 commented May 3, 2024

Thanks @saragunnarsson. Let's wait for Liz to confirm and have a new ticket if need be.

@chdivyareddy
Copy link
Collaborator

chdivyareddy commented May 3, 2024

Hey @dimak1 , looks like something is broken here...please take a look, thanks!!

  • When a new owner is added in the existing group (TIC), then it should display 'Edit' and 'Remove Owner' button beside the owner instead of 'Delete Owner'
  • When a new owner is added to an existing group with executors (TIC) and without groups, then the mix of owners error validation is not displayed (user can delete one executor if there are 2 or more, but cannot have mix of owners/executors/admins):

Screenshot 2024-05-03 at 1.20.50 PM.png

Expected:
image.png

image.png

@dimak1
Copy link
Collaborator

dimak1 commented May 3, 2024

@chdivyareddy thanks, I will take a look.

@dimak1
Copy link
Collaborator

dimak1 commented May 7, 2024

Hi Divya, I fixed both items: the menu and the validations (screenshots below). For validations, as per requirement (in pink), I removed 2nd validation rule, so if one exec/admin/trustee is removed, it will not trigger error for all owners to be removed.

Screenshot 2024-05-07 at 05.37.00.png

Screenshot 2024-05-07 at 05.31.06.png

1 similar comment
@dimak1
Copy link
Collaborator

dimak1 commented May 7, 2024

Hi Divya, I fixed both items: the menu and the validations (screenshots below). For validations, as per requirement (in pink), I removed 2nd validation rule, so if one exec/admin/trustee is removed, it will not trigger error for all owners to be removed.

Screenshot 2024-05-07 at 05.37.00.png

Screenshot 2024-05-07 at 05.31.06.png

@dimak1
Copy link
Collaborator

dimak1 commented May 7, 2024

Ready in DEV.

@dimak1
Copy link
Collaborator

dimak1 commented May 8, 2024

@chdivyareddy fixed validation for Transfers and merged to DEV.

@dimak1
Copy link
Collaborator

dimak1 commented May 8, 2024

Increasing estimate due to amount of work put into this ticket.

@LizGovier
Copy link
Collaborator

Hey @saragunnarsson @dimak1 @chdivyareddy

In reference to :

Do we prefill the Interest values in the Amount Owned & Total Available fields? Right now, it is prefilled when existing and new groups are selected from the dropdown.

Sara is correct, when registering a group we should autofill the value for subsequent groups, but if the group is edited we should not change the value for the rest of the groups.

@PCC199 PCC199 closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants