Update Misc Transfers Ownership #1856
Conversation
|
/gcbrun |
| fractionalOwnershipData: computed((): FractionalOwnershipWithGroupIdIF => { | ||
| // for New Group (the last one in dropdown), reset interest values | ||
| if (localState.groupItems.length === localState.ownerGroupId) { | ||
| props.fractionalData.interestNumerator = null // eslint-disable-line vue/no-mutating-props | ||
| props.fractionalData.interestDenominator = null // eslint-disable-line vue/no-mutating-props | ||
| } | ||
| return props.fractionalData | ||
| }), |
There was a problem hiding this comment.
There was a previous explicit requirement to put in default interest values for New Groups, so i'm confused by this a little.
I guess the question is:
Has this requirement changed/since been reversed? Can we confirm this from all parties? ie design/qa etc
If so, we should just remove the code that applies the defaults, which i think is code block starting line 603 in add/edit owner component
There was a problem hiding this comment.
This was raised by Divya. I was also surprised by this, so just waiting for clarification from her.
There was a problem hiding this comment.
Sara could not confirm this, so we removed it for this PR. If Liz says we need it cleared, they will create a new ticket.
|
Temporary Url for review: https://bcregistry-assets-dev--pr-1856-46o9ljb8.web.app |
dimak1
force-pushed
the
feat/update-misc-transfers
branch
from
0ede9fd to
de46b60
Compare
dimak1
changed the title
Issue #:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).