Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal API: allowable actions (do before #18750) #18784

Closed
5 tasks done
argush3 opened this issue Nov 28, 2023 · 3 comments
Closed
5 tasks done

Legal API: allowable actions (do before #18750) #18784

argush3 opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
ENTITY Business Team

Comments

@argush3
Copy link
Collaborator

argush3 commented Nov 28, 2023

Assuming that an initial implementation of allowable actions for amalgamation is in place to support creating a bootstraped business via #18460.

Finish implementation in this ticket.

Talk to Argus before starting this ticket.

TODOs

  • Update amalgamation allowable action for a specific business to block on pending future effective dissolution filing
  • Add support for new businesses and existing businesses logic in amalgamation allowable action
  • Ensure authorization logic when submitting an amalgamation filing is integrated properly with amalgamation allowable action
  • Add amalgamation to allowable actions spreadsheet
  • Add/update unit tests
@argush3
Copy link
Collaborator Author

argush3 commented Dec 12, 2023

Have talked with James about this ticket. Will unassign him and assign him to a better first issue(#18954).

I will finish this one off. cc: @jdyck-fw @Mihai-QuickSilverDev @davemck513

@chenhongjing
Copy link
Collaborator

Thanks, Argus! 😸

@argush3
Copy link
Collaborator Author

argush3 commented Dec 15, 2023

Verified to be working in Dev with BC0871474 using BCREG0018.

Steps used for verification in Dev:

  1. Load a business that has no amalgamation blocker conditions that can be used to initiate an amalgamation.
  2. Verify via network tab in browser that business response comes back with amalgamation filings in allowable actions.
  3. File a future effective dated voluntary dissolution on selected business.
  4. Verify via network tab in browser that business response does not contain amalgamation filings in allowable actions.

Step 2 Verification Results
image.png

Step 4 Verification Results
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

6 participants