Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18784 Update allowable actions for amalgamation #2352

Merged
merged 12 commits into from
Dec 14, 2023
Merged

Conversation

chenhongjing
Copy link
Collaborator

Issue #: /bcgov/entity#18784

Description of changes:

  • updated allowable actions for amalgamation
  • fix unit tests
  • rename amalgamation to amalgamationApplication

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@chenhongjing chenhongjing self-assigned this Dec 11, 2023
@chenhongjing chenhongjing marked this pull request as ready for review December 11, 2023 15:44
@argush3
Copy link
Collaborator

argush3 commented Dec 11, 2023

can we add a test to test the future effective dissolution scenario for amalgamations?

@argush3 argush3 assigned argush3 and unassigned chenhongjing Dec 12, 2023
chenhongjing and others added 12 commits December 13, 2023 15:17
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

7.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@argush3
Copy link
Collaborator

argush3 commented Dec 13, 2023

@vysakh-menon-aot @kzdev420 this should be ready for review whenever you have a minute. Thanks!

@argush3 argush3 merged commit 9ef825e into bcgov:main Dec 14, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants