Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create UI: NR error on submitting a Restoration #19822

Closed
Mihai-QuickSilverDev opened this issue Feb 13, 2024 · 2 comments
Closed

Create UI: NR error on submitting a Restoration #19822

Mihai-QuickSilverDev opened this issue Feb 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Mihai-QuickSilverDev
Copy link
Collaborator

Mihai-QuickSilverDev commented Feb 13, 2024

Submission of a Restoration lacks NR identification details, crushing the filing.

Steps to reproduce:

  1. create and approve a restoration NR for a historical business but do not affiliate the NR to your current account
  2. start a restoration filing for the historical business
  3. add a NR (need phone or email)
  4. complete and try to submit the filing
  5. see error

image.png

@Mihai-QuickSilverDev Mihai-QuickSilverDev added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Feb 13, 2024
@severinbeauvais severinbeauvais added the bug Something isn't working label Feb 13, 2024
@severinbeauvais severinbeauvais self-assigned this Feb 13, 2024
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Feb 13, 2024

After investigation, I found that the root cause is that the phone/email that the user entered when adding this NR was not retained, and is therefore not used when validating the NR right before submission (or if the filing is saved and resumed).

A likely work-around is to affiliate the NR to the current account before doing the restoration. (In the problem description above, I did not find a restoration NR affiliated to account 1999. Had one been, the restoration filing likely would have succeeded.)

I believe this issue would have affected Continuation In and Amalgamation (regular) filings as well.

As part of the investigation, I came up with a fix, so I might as well finish implementing this ticket.

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Feb 14, 2024

Test Notes

Try the following with NRs that are, and aren't, affiliated to your current account. (Both should work.)

Part of the fix affects NR retrieval during app start-up (eg, IA, registration, restoration, continuation in, amalgamation), so those should be tested with NRs (including save and resume).

The main fix is in the File and Pay handling (NR validation). This applies to IAs, registration, restorations, continuation ins and amalgamations.

The last part of the fix is to save, and resume, the applicant's email and phone in the draft filing. (You can see it in the Network tab in the nameRequest object of the draft filing.) This only applies to amalgamations, continuation ins and restorations.

(I have personally tested variations of the above.)

@severinbeauvais severinbeauvais changed the title NR error on submitting a Full Restoration Create UI: NR error on submitting a Full Restoration Feb 14, 2024
@severinbeauvais severinbeauvais changed the title Create UI: NR error on submitting a Full Restoration Create UI: NR error on submitting a Restoration Feb 14, 2024
@NaveenHebbale NaveenHebbale removed the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants