-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create UI: NR error on submitting a Restoration #19822
Comments
After investigation, I found that the root cause is that the phone/email that the user entered when adding this NR was not retained, and is therefore not used when validating the NR right before submission (or if the filing is saved and resumed). A likely work-around is to affiliate the NR to the current account before doing the restoration. (In the problem description above, I did not find a restoration NR affiliated to account 1999. Had one been, the restoration filing likely would have succeeded.) I believe this issue would have affected Continuation In and Amalgamation (regular) filings as well. As part of the investigation, I came up with a fix, so I might as well finish implementing this ticket. |
Test NotesTry the following with NRs that are, and aren't, affiliated to your current account. (Both should work.) Part of the fix affects NR retrieval during app start-up (eg, IA, registration, restoration, continuation in, amalgamation), so those should be tested with NRs (including save and resume). The main fix is in the File and Pay handling (NR validation). This applies to IAs, registration, restorations, continuation ins and amalgamations. The last part of the fix is to save, and resume, the applicant's email and phone in the draft filing. (You can see it in the Network tab in the (I have personally tested variations of the above.) |
Submission of a Restoration lacks NR identification details, crushing the filing.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: