19822 Fixed NR validation on submit #656
Conversation
- use applicant phone/email (if available) to fetch NR on app start - use applicant phone/email (if available) to validate NR on file and pay - save applicant phone/email to draft amalgamation, continuation in and restoration - added store getter - misc cleanup - fixed unit tests
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-656-j1e446e4.web.app SB says, try this restoration filing (as staff) (with NR 6038389/1234/sss@ggg.ccc): SB says, try this incorporation application (as BCREG0020/Severin Dev Account): |
severinbeauvais
requested review from
JazzarKarim,
kzdev420 and
ketaki-deodhar
| this.nameRequestInvalidErrorDialog = true | ||
| }) | ||
| const applicantPhone = filing[filing.header?.name].nameRequest.applicantPhone // may be undefined | ||
| const applicantEmail = filing[filing.header?.name].nameRequest.applicantEmail // may be undefined |
There was a problem hiding this comment.
Sample filing JSON:
| @@ -857,6 +862,8 @@ export default class FilingTemplateMixin extends Mixins(AmalgamationMixin, DateM | |||
| filing.restoration.nameRequest.correctNameOption = CorrectNameOptions.CORRECT_NEW_NR | |||
| filing.restoration.nameRequest.legalName = this.getNameRequestApprovedName | |||
| filing.restoration.nameRequest.nrNumber = this.getNameRequestNumber | |||
| filing.restoration.nameRequest.applicantPhone = this.getNameRequestApplicant.phoneNumber | |||
| filing.restoration.nameRequest.applicantEmail = this.getNameRequestApplicant.emailAddress | |||
There was a problem hiding this comment.
Sample filing JSON: (same screenshot as above)
For some reason, I can't open both links (This filing type is not available at the moment. Please check again later.). Pretty sure it's unrelated to the work here though. |
Weird. I just accessed both from my cell! Login with IDIR for the first one and BCREG0020 for the second one. |
Oops, this should have been 5.9.0. Not that it matters much, and I do think this is a large enough change (since it affects at least 3 filings) to merit a minor version bump. |
- use applicant phone/email (if available) to fetch NR on app start - use applicant phone/email (if available) to validate NR on file and pay - save applicant phone/email to draft amalgamation, continuation in and restoration - added store getter - misc cleanup - fixed unit tests Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
Issue #: bcgov/entity#19822
Description of changes:
- app version = 5.9.1
- use applicant phone/email (if available) to fetch NR on app start
- use applicant phone/email (if available) to validate NR on file and pay
- save applicant phone/email to draft amalgamation, continuation in and restoration
- added store getter
- misc cleanup
- fixed unit tests
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).