Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIs - update NAICS urls to point at GCP legal api #20293

Closed
3 tasks done
argush3 opened this issue Mar 13, 2024 · 2 comments
Closed
3 tasks done

UIs - update NAICS urls to point at GCP legal api #20293

argush3 opened this issue Mar 13, 2024 · 2 comments
Assignees
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team

Comments

@argush3
Copy link
Collaborator

argush3 commented Mar 13, 2024

Currently, UIs that use NAICs endpoint are still going to OCP legal api.

In GCP Dev, the relevant legal name UIs will need to point at GCP legal api.

TODOs

  • Add API vault in 1pass to have a temp entry for following config that UIs use - VUE_APP_NAICS_API_URL="op://API/$APP_ENV/naics-api/NAICS_API_URL". Ask Argus or someone with access to add 1pass entry so the following value can be used in UIs op://API/$APP_ENV/naics-api-le/NAICS_API_URL
  • Update create & edit ui to reference new config for naics api url
  • Verify UIs are calling GCP legal api urls when doing NAICS searches
@argush3 argush3 added Entities - David A label to filter on the tickets for the Entities based team that David is PO for. ENTITY Business Team labels Mar 13, 2024
@NaveenHebbale NaveenHebbale added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Mar 20, 2024
@severinbeauvais severinbeauvais self-assigned this Mar 21, 2024
@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Mar 21, 2024

Test Notes

You can use this SP/DBA registration for testing the NAICS lookup:
https://business-create-le-dev.web.app/registration-define-business?id=Tv6ytOQuHz

You can use one of these active firms for testing the NAICS lookup (change or correction filing):
https://business-filings-le-dev.web.app/FM0020270 (GP)
https://business-filings-le-dev.web.app/FM0555153 (SP)
https://business-filings-le-dev.web.app/FM1000001 (GP)
https://business-filings-le-dev.web.app/FM1018902 (GP)
https://business-filings-le-dev.web.app/FM1052390 (SP)

Sample call from Create UI (registration filing):

image.png

Sample call from Edit UI (change filing):

image.png

@NaveenHebbale
Copy link

GCP testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. ENTITY Business Team
Projects
None yet
Development

No branches or pull requests

3 participants