20293 Updated NAICS URL (for legal name branch) #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- app version = 6.0.1 - updated NAICS API reference in vaults file
|
/gcbrun |
|
Temporary Url for review: https://business-create-dev--pr-669-mx5h9zjn.web.app SB says, try this registration filing: https://business-create-dev--pr-669-mx5h9zjn.web.app/registration-define-business?id=Tv6ytOQuHz |
severinbeauvais
commented
Mar 21, 2024
| @@ -8,19 +8,15 @@ VUE_APP_ADDRESS_COMPLETE_KEY= | |||
| VUE_APP_REGISTRY_HOME_URL="https://dev.bcregistry.gov.bc.ca/" | |||
| VUE_APP_AUTH_WEB_URL="https://dev.account.bcregistry.gov.bc.ca/" | |||
| VUE_APP_BUSINESSES_URL="https://dev.account.bcregistry.gov.bc.ca/" | |||
| # for Legal Name feature branch only: | |||
There was a problem hiding this comment.
This is legal name branch code, so I didn't see a reason to keep this comment or the main branch values below.
There was a problem hiding this comment.
PS For folks working on the UIs in legal name branch, please update VUE_APP_NAICS_API_URL in your .env file also.
severinbeauvais
commented
Mar 21, 2024
| VUE_APP_NAICS_API_URL="op://API/$APP_ENV/naics-api/NAICS_API_URL" | ||
| VUE_APP_NAICS_API_VERSION_2="op://API/$APP_ENV/naics-api/NAICS_API_VERSION" | ||
| VUE_APP_NAICS_API_URL="op://API/$APP_ENV/naics-api-le/NAICS_API_URL" | ||
| VUE_APP_NAICS_API_VERSION_2="op://API/$APP_ENV/naics-api-le/NAICS_API_VERSION" |
There was a problem hiding this comment.
I created this new section in the API vaul in 1Password (for Dev + Test + Prod).
There was a problem hiding this comment.
Should've went to this PR first 😆 Got my answer 👍
JazzarKarim
reviewed
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#20293
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).