Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legal API: return more properties in reviews response #22580

Closed
2 of 4 tasks
severinbeauvais opened this issue Jul 31, 2024 · 4 comments
Closed
2 of 4 tasks

Legal API: return more properties in reviews response #22580

severinbeauvais opened this issue Jul 31, 2024 · 4 comments
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 31, 2024

An updated design requires:

  • the display of Future Effective Date in the staff dashboard Continuation Applications table
  • an alert icon (orange( when a NR will expire soon (14 days)
  • an action to open the NR in Namex

The above requirements need the following additional properties in the reviews endpoint response:

  • future effective date
  • NR expiry date
  • NR identifier
  • NR phone or email (for opening in Namerequest UI)

Do not fetch NR data for reviews in Approved/Rejected/Abandoned state.

Note that there is a Namex API endpoint that supports retrieval of multiple NRs at once, so performance should not be an issue. (And anyway, the maximum response page size set by the UI is 20, so that's the maximum number of NRs to retrieve at once.)

@severinbeauvais severinbeauvais added the Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. label Jul 31, 2024
@severinbeauvais severinbeauvais changed the title Legal API: return Future Effective Date in reviews response Legal API: return more properties in reviews response Aug 1, 2024
@vikas-gov vikas-gov mentioned this issue Aug 7, 2024
19 tasks
@ketaki-deodhar ketaki-deodhar self-assigned this Aug 7, 2024
@ketaki-deodhar
Copy link
Collaborator

This is On Hold to finish API spec tickets as a priority

@severinbeauvais
Copy link
Collaborator Author

Note: I've updated the requirements. As the UI will now redirect to Namex UI, we don't need the NR id or phone/email keys.

@ketaki-deodhar
Copy link
Collaborator

Thanks for the update @severinbeauvais

@ketaki-deodhar
Copy link
Collaborator

ketaki-deodhar commented Aug 23, 2024

Sample json.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.
Projects
None yet
Development

No branches or pull requests

3 participants