Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth Web: add tooltips and Open Name Request button to staff dashboard #22579

Closed
10 tasks done
severinbeauvais opened this issue Jul 31, 2024 · 18 comments
Closed
10 tasks done
Assignees
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Jul 31, 2024

Figma:
https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=2983-13864&t=snJ3B018XsotFX1j-0
https://www.figma.com/design/wVF8EcUCUR20YyqA0wHVJp/Continuation-In-V5?node-id=560-2&t=XD1CLv82Tv5xi57m-0

Assume we are implemention Option 1 - split buttons / dropdown menu to open NR.

Assume the Legal API endpoint provides the necessary future effective date and NR data - #22580.

To do:

  • add Future Effective Date column to table
    • add tooltip to show date + time (see Filing History items for example)
    • including date pickers to filter by date range
    • including sorting option
  • add orange tooltip to future effective date-time if date is < 3 days away
    • this number may change
  • add red tooltip to future effective date if date-time has passed
  • add orange tooltip to NR number if it will expire in < 14 days
  • add red tooltip to NR number if it has expired
  • add action to open a NR (if application uses a NR)
    • redirect to Namex UI (may need new 1Pass/env keys)
  • add hover text showing what statuses are selected
  • show the date range truncated and the full text on hover
  • Added close icon to all search fields
  • Fixed the bug: calendar icon can't open the date picker

Note that NRs for Approved/Rejected/Abandoned reviews will not have an expiry date or id or phone/email, so do not show the "open name request" action for these ones.

@severinbeauvais severinbeauvais added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance labels Jul 31, 2024
@severinbeauvais severinbeauvais changed the title Auth Web: add tooltips and NR renew button to staff dashboard Auth Web: add tooltips and Open Name Request button to staff dashboard Aug 7, 2024
@vikas-gov vikas-gov mentioned this issue Aug 7, 2024
19 tasks
@severinbeauvais
Copy link
Collaborator Author

@janisrogers @andyyanggov
Janis, can you please review the requirements above and the UI design and see if it looks OK to you? Thanks.

@ArwenQin ArwenQin self-assigned this Aug 15, 2024
@ArwenQin
Copy link
Collaborator

@janisrogers
Hi Janis, may I know what should the tooltips say? Thanks.

  • Future effective: red and orange tooltips
  • NR: red and orange tooltips

@vikas-gov vikas-gov mentioned this issue Aug 16, 2024
14 tasks
@janisrogers
Copy link
Collaborator

janisrogers commented Aug 19, 2024

The tooltips are on the 'Staff Dashboard' page of the design. @ArwenQin I have updated the link above.

@ArwenQin
Copy link
Collaborator

@janisrogers
Hi Janis, may I know when redirect to the Namex UI, should the Name Examination open in a new page (tab) ?

@janisrogers
Copy link
Collaborator

@ArwenQin Yes, a new tab would be best. Thanks

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Aug 22, 2024

Release Notes

A new environment key was added to route to Name Examination (NAMEX_WEB_URL). I have already added the Dev/Test/Prod keys to 1Password. Nothing else needs to be done for this.

@ArwenQin
Copy link
Collaborator

ArwenQin commented Aug 22, 2024

Hi Mihai and Janis, just to confirm:
Do you think we should be able to open the Name Examination UI when the application is approved or rejected?
@Mihai-QuickSilverDev @janisrogers
image.png

image.png

cc: @severinbeauvais

@janisrogers
Copy link
Collaborator

@Mihai-QuickSilverDev Do you know what the staff would prefer. I don't see any reason to not allow it, but I don't know if it is needed.

@vikas-gov
Copy link
Collaborator

@ArwenQin
Copy link
Collaborator

ArwenQin commented Aug 23, 2024

@janisrogers
Hi Janis, 2 more items to confirm:

  1. For the future effective date: when the FED is less than 1 day, should show hours instead of days in the tooltip?
    As a possible solution, how about if the dates have their own tooltip like this?

image.png

  1. For the NR expiring today ( less than 1 day), should it show "expiring today" or "expires in 1 day"?

image.png

CC: @severinbeauvais

@janisrogers
Copy link
Collaborator

Question 1 above. I like your solution of the tooltip
Question 2, It should say The Name Request will expire today. (with today bolded)

@ArwenQin
Copy link
Collaborator

Hi Mihai, May I know what is your thoughts on
whether we should be able to open the Name Examination UI when the application is approved or rejected?
image.png

image.png

@Mihai-QuickSilverDev

@Mihai-QuickSilverDev
Copy link
Collaborator

Hi @ArwenQin I have just tested in Names UI, and the NR is available to the user in both states, approved or rejected. So I think it should be available here too. I am not sure if the MBR would have the required credentials to authenticate the user, or if they would have to authenticate in Names UI.
@severinbeauvais

@severinbeauvais
Copy link
Collaborator Author

severinbeauvais commented Aug 26, 2024

Mihai, it will be fine. The link to the NR is on the staff dashboard. We simply redirect them to Namex UI. No additional authentication needed. Thanks for you quick response!

@vikas-gov vikas-gov mentioned this issue Aug 29, 2024
15 tasks
@janisrogers
Copy link
Collaborator

Suggestions for improvement

  • When NR Expiry is within one day, should change 'days' to 'day'

image.png

  • regarding the truncated date range - can we show '...' in the search box to indicate more? If I look at this without the hover text, it appears to be Aug 1 - Aug 2, when actually it is Aug 1 - Aug 29

image.png

  • When the clear filter icon ('X') shows in the calendar field, please remove the calendar icon. Having two icons looks odd to me.

FED Issues - Fixing these should probably be put on hold pending future design:

  • There is a problem with the date picker for future effective date. I cannot pick a date in the future.

image.png

  • When fed is within one day, should change 'days' to 'day'

image.png

Everything else looks good.

@severinbeauvais
Copy link
Collaborator Author

@ArwenQin Please look at the issues above and decide:

  • If they fit in an existing review table bug ticket (and copy them there)
  • If they need a new bug ticket (which we will decide to work later)

Thanks!

@ArwenQin
Copy link
Collaborator

ArwenQin commented Sep 3, 2024

@janisrogers @severinbeauvais
Thank you Janis and Severin.
I included all of the NR date/FED issues in ticket 23032
https://app.zenhub.com/workspaces/entities---olga-65af15f59e89f5043c2911f7/issues/gh/bcgov/entity/23032

@severinbeauvais
Copy link
Collaborator Author

The new ticket looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. UX Assurance
Projects
None yet
Development

No branches or pull requests

5 participants