Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VERIFY] Auth Web: The date picker is only activated when interacting with the 8x8 padding section of the submitted date column. #22913

Closed
riyazuddinsyed opened this issue Aug 21, 2024 · 11 comments
Assignees
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.

Comments

@riyazuddinsyed
Copy link
Collaborator

Describe the bug in the current situation
When the staff clicks on the Date Picker symbol or label then the date picker is not activated as it does with other components using similar functionality

Steps to reproduce the behavior:

  1. Go to 'https://dev.account.bcregistry.gov.bc.ca/staff/dashboard/active'
  2. Login as Staff
  3. Try to click on the date picker label
  4. Try clicking on the 8X8 padding section then only the Date picker enables

Screenshots/ Visual Reference/ Source
Screen Shot 2024-08-21 at 12.12.26 PM.png

@riyazuddinsyed riyazuddinsyed added bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Aug 21, 2024
@severinbeauvais
Copy link
Collaborator

@ArwenQin I looked at the code and it seems that clicking the icon resets the date range, but this is not at all obvious from the UI itself. Please check with Janis on whether the calendar icon should be replaced with an 'X' icon or whatever.

@severinbeauvais severinbeauvais changed the title The date picker is only activated when interacting with the 8x8 padding section of the submitted date column. Auth Web: The date picker is only activated when interacting with the 8x8 padding section of the submitted date column. Aug 22, 2024
@severinbeauvais
Copy link
Collaborator

I looked at the code and it seems that clicking the icon resets the date range, but this is not at all obvious from the UI itself. Please check with Janis on whether the calendar icon should be replaced with an 'X' icon or whatever.

My mistake. The calendar icon does nothing. An 'X' icon already displays to reset the date range. The question now is, should we add an action to the calendar icon or delete it?

@ArwenQin
Copy link
Collaborator

@janisrogers
Hi Janis, the date picker has a calendar icon which does nothing when click it.
Should we add an action to the calendar icon or delete it?
image.png

@janisrogers
Copy link
Collaborator

Yes, if you can add the action to the icon that would be great. It should open the calendar, same as clicking in the field.

@severinbeauvais
Copy link
Collaborator

Janis, is it ok that 2 icons may be displayed at the same time (clear + calendar)?

@vikas-gov
Copy link
Collaborator

will be fixed by #22579

@vikas-gov vikas-gov changed the title Auth Web: The date picker is only activated when interacting with the 8x8 padding section of the submitted date column. [VERIFY] Auth Web: The date picker is only activated when interacting with the 8x8 padding section of the submitted date column. Aug 22, 2024
@severinbeauvais
Copy link
Collaborator

@ArwenQin , are you able to fix this as part of your current ticket?

@ArwenQin
Copy link
Collaborator

should open the calendar, same as clicking in the field.

Sure, I will do it.

@severinbeauvais
Copy link
Collaborator

Great, thanks. Then this ticket can be verified after your current ticket is implemented/merged.

@ArwenQin
Copy link
Collaborator

Verified, now click the calendar icon, it opens the date picker too.
image.png

@severinbeauvais
Copy link
Collaborator

Arwen, you can move this to Done. Change the estimate to "1" if you feel you needed extra time for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for.
Projects
None yet
Development

No branches or pull requests

6 participants