Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit UI: allow editable Certify Legal Name #23971

Closed
severinbeauvais opened this issue Oct 22, 2024 · 10 comments
Closed

Edit UI: allow editable Certify Legal Name #23971

severinbeauvais opened this issue Oct 22, 2024 · 10 comments
Assignees
Labels
bug Something isn't working Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Priority2

Comments

@severinbeauvais
Copy link
Collaborator

severinbeauvais commented Oct 22, 2024

In an Alteration, as a regular user, it's not currently possible to edit the Certify Legal Name field. This field needs to be editable.

Please check other filings in Edit UI and fix as needed.

@severinbeauvais severinbeauvais added Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. Priority2 labels Oct 22, 2024
@severinbeauvais severinbeauvais changed the title Copy of Create UI: allow editable Certify Legal Name Edit UI: allow editable Certify Legal Name Oct 22, 2024
@severinbeauvais severinbeauvais added the bug Something isn't working label Oct 24, 2024
@davemck513 davemck513 added Entities - David A label to filter on the tickets for the Entities based team that David is PO for. and removed Entities - Olga A label to filter on the tickets for the Entities based team that Olga is PO for. labels Oct 30, 2024
@eason-pan-bc eason-pan-bc self-assigned this Oct 30, 2024
@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Oct 31, 2024

@severinbeauvais a quick question, are firms & coops in the scope of this fix? e.g. Change filing for SPs?

@severinbeauvais
Copy link
Collaborator Author

@OlgaPotiagalova @Mihai-QuickSilverDev Should we allow editable Certify Legal Name for firms and coops, too?

@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Oct 31, 2024

@severinbeauvais another question, since we are looking at the issue of cannot edit certify legal name as a regular user, we don't need to change this part for staff-only filings right? Since regular users won't be able to touch the staff-only filings, then they won't get into the page to edit the certify info. Is it correct?

@severinbeauvais
Copy link
Collaborator Author

I think you're asking about firm conversion and corrections, right? Yes, those are staff-only right now, though I've heard that we might open corrections to regular users later.

I'd make sure that the Certify Legal Name is editable in all filings where it's displayed, just to be safe.

@eason-pan-bc
Copy link
Collaborator

I think you're asking about firm conversion and corrections, right? Yes, those are staff-only right now, though I've heard that we might open corrections to regular users later.

I'd make sure that the Certify Legal Name is editable in all filings where it's displayed, just to be safe.

Make sense, thank you Sev 😄

@eason-pan-bc
Copy link
Collaborator

@OlgaPotiagalova @Mihai-QuickSilverDev Should we allow editable Certify Legal Name for firms and coops, too?

Hi Sev, just wondering if you've heard anything back for firms and coops?

@severinbeauvais
Copy link
Collaborator Author

Nope. Olga and Mihai would have received an email notification and are surely working to catch up and respond.

Is Certify Legal Name currently editable for firms and coops?

If you need a decision asap, please contact your PO or Olga or Mihai directly.

@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Nov 1, 2024

Nope. Olga and Mihai would have received an email notification and are surely working to catch up and respond.

Is Certify Legal Name currently editable for firms and coops?

If you need a decision asap, please contact your PO or Olga or Mihai directly.

Thank you Sev.

For Change filings, the Certify Legal Name is currently not editable. And this is where we need some reqquirements confirmation.
For Correction filings, they are editable for anyone. But they are staff-only filings, so regular users currently won't be able to see theses pages.

I think will connect with Mihai this afternoon.

@eason-pan-bc
Copy link
Collaborator

eason-pan-bc commented Nov 5, 2024

Notes for QA

As per discussion with Mihai, we only focus on corps in this ticket.

Tested in DEV for corp, the Certify Legal Name section is editable for regular users now.

image.png

To Identify Edit_UI pages, looking at the URL, if there is xxxx.edit.xxx.xxx/xxx then it is an Edit_UI page.
image.png

@vishnup0422
Copy link
Collaborator

Alteration Filing Edit Legal name

Private Zenhub Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Entities - David A label to filter on the tickets for the Entities based team that David is PO for. Priority2
Projects
None yet
Development

No branches or pull requests

4 participants