Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23971 - allow editable certify legal name #594

Merged

Conversation

eason-pan-bc
Copy link
Collaborator

Issue #: /bcgov/entity#23971

Description of changes:
Allow Certify Legal Name section to be editable for regular users. As per discussion with Mihai, firms and coops are not considered in this ticket.

Filing Type is Editable Before is Editable Now Notes
alteration ✔️
limitedRestorationExtension ✔️ ✔️
limitedRestorationToFull ✔️ ✔️
specialResolution ✔️
CorpCorrection ✔️ ✔️
CoopCorrection ✔️ ✔️ Not considering Coops and Firms at this moment
change Not considering Coops and Firms at this moment
FirmCorrection ✔️ ✔️ Not considering Coops and Firms at this moment

Change Example - Alteration for a corp as a regular user

Before

Pasted image 20241031100156

Now

Pasted image 20241031100325

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@eason-pan-bc
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-edit-dev--pr-594-bn9uy8wh.web.app

Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (^_^)

@eason-pan-bc eason-pan-bc merged commit bc543b2 into bcgov:main Nov 2, 2024
8 of 10 checks passed
@eason-pan-bc
Copy link
Collaborator Author

Sorry, I forgot to squash and merge, will keep in mind next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants