Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23971 - allow editable certify legal name #594

Merged
merged 4 commits into from
Nov 2, 2024
Merged

23971 - allow editable certify legal name #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fab731
enable Certify for regular users in filings for corps
eason-pan-bc Oct 31, 2024
51be002
update test comments to describe their test goals
eason-pan-bc Oct 31, 2024
70ac5b9
bump up version number
eason-pan-bc Nov 1, 2024
e14e83f
lock package version
eason-pan-bc Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
severinbeauvais marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.11.1",
"version": "4.11.2",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
1 change: 0 additions & 1 deletion src/views/Alteration.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@
class="mt-10"
:sectionNumber="showTransactionalFolioNumber ? '3.' : '2.'"
:validate="getAppValidate"
:disableEdit="!isRoleStaff"
/>

<!-- STAFF ONLY: Court Order/Plan of Arrangement and Staff Payment -->
Expand Down
1 change: 0 additions & 1 deletion src/views/SpecialResolution.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@
class="mt-10"
:sectionNumber="showTransactionalFolioNumber ? '4.' : '3.'"
:validate="getAppValidate"
:disableEdit="!isRoleStaff"
/>

<template v-if="isRoleStaff">
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/Alteration.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ describe('Alteration component', () => {
expect(store.stateModel.filingData[0].filingTypeCode).toBe(FilingCodes.ALTERATION_BC_TO_ULC)
})

it('certify text is not prefilled/editable for staff user', async () => {
it('certify text is not prefilled for staff user', async () => {
store.stateModel.tombstone.keycloakRoles = ['staff']
store.stateModel.tombstone.userInfo = {
firstname: 'Jon',
Expand All @@ -425,7 +425,7 @@ describe('Alteration component', () => {
expect(store.stateModel.certifyState.certifiedBy).toBe('undefined undefined')
})

it('certify text is prefilled/uneditable for non-staff user', async () => {
it('certify text is prefilled for non-staff user', async () => {
store.stateModel.tombstone.keycloakRoles = []
store.stateModel.tombstone.userInfo = {
firstname: 'Jon',
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/SpecialResolution.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ describe('Special Resolution component', () => {
expect(store.stateModel.currentFees[0].filingFees).toBe(70)
})

it('certify text is not prefilled/editable for staff user', async () => {
it('certify text is not prefilled for staff user', async () => {
store.stateModel.tombstone.keycloakRoles = ['staff']
store.stateModel.tombstone.userInfo = {
firstname: 'Jon',
Expand All @@ -290,7 +290,7 @@ describe('Special Resolution component', () => {
expect(store.stateModel.certifyState.certifiedBy).toBe('undefined undefined')
})

it('certify text is prefilled/uneditable for non-staff user', async () => {
it('certify text is prefilled for non-staff user', async () => {
store.stateModel.tombstone.keycloakRoles = []
store.stateModel.tombstone.userInfo = {
firstname: 'Jon',
Expand Down
Loading