👷 Create lint and test workflow #63
Conversation
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
…er to upgrade to python 3.9 Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Someone else can figure it out later :-) Signed-off-by: ff137 <ff137@proton.me>
|
@esune, Assigning you and as reviewers since I think we should both take a look. Assigned to me to get it on my backlog. |
| python3_indy~=1.16.0.post286 |
There was a problem hiding this comment.
Did a quick scan, this doesn't seem to be imported anywhere - is it a transitive dependency?
There was a problem hiding this comment.
@esune import indy is used in the integration tests
There was a problem hiding this comment.
Will be great if there was an alternative way to achieve that integration testing, because figuring out how to install the libindy dependency on the docker image probably took me a good 2 hours of trial and error 😂
That's why Dockerfile.test now builds from ubuntu:20.04 and installs python separately, because that apt-get install libindy doesn't work on debian images, and python docker images all use debian, AFAICT
There was a problem hiding this comment.
Should migrate to indy-vdr at some point in the near future.
👷 Creates a lint-and-test.yaml github workflow, to automate testing and enforce some code style checks
👷 Add Dependabot pip dependency management config
➕ add black and isort dev dependencies
📌 pin dependency versions for best practice
🎨 apply black and isort formatting to python files
⬆️ Upgraded test dockerfile base image to use ubuntu:20, so that python can be upgraded to 3.9. Previous base image used 3.6, and ubuntu base image was chosen because it's easier to install the libindy dependency on ubuntu than debian, which official python base images run on.
(Side note: no offense, but it's kinda bad to be running Python 3.6 in 2024 -- it's been end-of-life since Dec 2021! And it's not a heavy lift to update to the new python versions - nevertheless it will be a process to make that migration across the board)