Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INSPECT-XXX][REFACTOR] - lucy-338 changed payload to match with db for stationInformation #343

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[INSPECT-XXX][REFACTOR] - lucy-338 changed payload to match with db for stationInformation #343

merged 1 commit into from
Dec 23, 2024

Conversation

PaulGarewal
Copy link
Contributor

@PaulGarewal PaulGarewal commented Dec 22, 2024 •
edited
Loading

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [INSPECT-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

@PaulGarewal PaulGarewal self-assigned this Dec 22, 2024
@PaulGarewal PaulGarewal mentioned this pull request Dec 22, 2024
Merged
4 tasks
@PaulGarewal PaulGarewal requested a review from a team December 22, 2024 00:22
PaulGarewal
PaulGarewal commented Dec 22, 2024
View reviewed changes
ipad/Models/Shift/ShiftModel.swift
@@ -273,7 +273,7 @@ class ShiftModel: Object, BaseRealmObject {
"location": "NA",
"motorizedBlowBys": motorizedBlowBys,
"nonMotorizedBlowBys": nonMotorizedBlowBys,
"stationComments": stationComments.count > 1 ? stationComments : "",
"stationInformation": stationComments.count > 1 ? stationComments : "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the small change required to match the db

@PaulGarewal PaulGarewal linked an issue Dec 22, 2024 that may be closed by this pull request
Database Update for Station Information #338
Closed
1 task
@PaulGarewal PaulGarewal merged commit 87bb80d into master Dec 23, 2024
3 checks passed
@PaulGarewal PaulGarewal deleted the 338-db-payload-change branch December 23, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergmac fergmac fergmac approved these changes

Assignees

@PaulGarewal PaulGarewal

Labels
Frontend GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database Update for Station Information
2 participants
@PaulGarewal @fergmac