Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sre emails #2174

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Sre emails #2174

merged 2 commits into from
Aug 15, 2023

Conversation

bolyachevets
Copy link
Collaborator

@bolyachevets bolyachevets commented Aug 15, 2023

Issue #: /bcgov/entity/17214

Description of changes: update letter contents based on https://preview.uxpin.com/86ca5ddbe4d40318d3395577c17d4a692946fd27#/pages/163300702/simulate/no-panels

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@bolyachevets bolyachevets requested a review from pwei1018 August 15, 2023 17:14
@pwei1018 pwei1018 self-assigned this Aug 15, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #2174 (fe312b4) into main (53b46e4) will decrease coverage by 0.05%.
Report is 25 commits behind head on main.
The diff coverage is 64.10%.

@@            Coverage Diff             @@
##             main    #2174      +/-   ##
==========================================
- Coverage   77.16%   77.12%   -0.05%     
==========================================
  Files         222      222              
  Lines       12759    12706      -53     
  Branches     2126     2113      -13     
==========================================
- Hits         9846     9799      -47     
+ Misses       2272     2268       -4     
+ Partials      641      639       -2     
Flag Coverage Δ
entityemailer 71.88% <64.10%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legal-api/src/legal_api/core/filing.py 86.47% <ø> (-0.05%) ⬇️
legal-api/src/legal_api/core/meta/filing.py 91.17% <ø> (+1.26%) ⬆️
legal-api/src/legal_api/reports/report.py 27.75% <ø> (+0.23%) ⬆️
...gal_api/services/filings/validations/alteration.py 82.85% <ø> (-0.17%) ⬇️
legal-api/src/legal_api/services/pdf_service.py 100.00% <ø> (ø)
legal-api/src/legal_api/version.py 100.00% <ø> (ø)
...ailer/email_processors/dissolution_notification.py 48.14% <0.00%> (-0.45%) ⬇️
...r/src/entity_filer/filing_processors/alteration.py 92.00% <ø> (-0.31%) ⬇️
...r/src/entity_filer/filing_processors/correction.py 92.30% <ø> (-2.57%) ⬇️
.../src/entity_filer/filing_processors/dissolution.py 80.35% <ø> (-0.35%) ⬇️
... and 14 more

@bolyachevets bolyachevets merged commit 87a1e24 into bcgov:main Aug 15, 2023
@bolyachevets bolyachevets deleted the sre-emails branch August 15, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants