18163 AGM location change update filer and validations #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodube-aot
commented
Oct 24, 2023
| assert filing_json['filing']['agmLocationChange']['newAgmLocation']['addressCity'] == \ | ||
| agm_location.get('addressCity') | ||
| assert filing_json['filing']['agmLocationChange']['agmLocation'] == agm_location_change.get('agmLocation') | ||
| assert filing_json['filing']['agmLocationChange']['reason'] == agm_location_change.get('reason') |
There was a problem hiding this comment.
Once bcgov/business-schemas#146 gets merged, I will update the business schema version in the requirements so that the example data gets updated.
Codecov Report
@@ Coverage Diff @@
## main #2258 +/- ##
==========================================
+ Coverage 77.03% 77.37% +0.33%
==========================================
Files 161 202 +41
Lines 9838 11602 +1764
Branches 1660 1961 +301
==========================================
+ Hits 7579 8977 +1398
- Misses 1801 2043 +242
- Partials 458 582 +124
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Looks good but let's see what comes out of the schema review. |
|
Kudos, SonarCloud Quality Gate passed!
|
argush3
approved these changes
Oct 26, 2023
kzdev420
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#18163
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).