Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18233 bump version nums #2295

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

argush3
Copy link
Collaborator

@argush3 argush3 commented Nov 7, 2023

Issue #: /bcgov/entity#18233

Description of changes:

  • bump version numbers for following:
    • legal api
    • filer
    • entity-bn
    • emailer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@argush3 argush3 self-assigned this Nov 7, 2023
Copy link

sonarqubecloud bot commented Nov 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #2295 (4a18f3c) into main (79511cd) will decrease coverage by 3.11%.
Report is 12 commits behind head on main.
The diff coverage is 53.43%.

@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
- Coverage   77.37%   74.27%   -3.11%     
==========================================
  Files         202      241      +39     
  Lines       11602    13877    +2275     
  Branches     1961     2324     +363     
==========================================
+ Hits         8977    10307    +1330     
- Misses       2043     2902     +859     
- Partials      582      668      +86     
Flag Coverage Δ
entitybn 30.53% <100.00%> (?)
entityemailer 71.61% <66.27%> (?)
entityfiler 80.40% <100.00%> (ø)
legalapi 76.12% <49.13%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/config.py 95.16% <100.00%> (+0.28%) ⬆️
legal-api/src/legal_api/core/filing.py 86.50% <ø> (ø)
legal-api/src/legal_api/core/meta/filing.py 91.11% <ø> (ø)
legal-api/src/legal_api/models/__init__.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/models/dc_definition.py 90.69% <100.00%> (ø)
legal-api/src/legal_api/services/authz.py 94.54% <ø> (ø)
...gal_api/services/filings/validations/alteration.py 83.01% <100.00%> (ø)
legal-api/src/legal_api/version.py 100.00% <100.00%> (ø)
queue_services/entity-bn/src/entity_bn/config.py 100.00% <100.00%> (ø)
queue_services/entity-bn/src/entity_bn/version.py 100.00% <100.00%> (ø)
... and 15 more

... and 29 files with indirect coverage changes

@argush3 argush3 marked this pull request as ready for review November 7, 2023 16:00
@argush3 argush3 merged commit 6a82db0 into bcgov:main Nov 7, 2023
20 of 21 checks passed
@argush3 argush3 deleted the 18233_bump_version_nums branch November 7, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants