Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18240-Expiring-Soon-Emails #2324

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

Rajandeep98
Copy link
Collaborator

*Issue : #2306 bcgov/entity#18240

Description of changes:
updated condition

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #2324 (206d090) into main (79511cd) will decrease coverage by 0.59%.
Report is 32 commits behind head on main.
The diff coverage is 56.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
- Coverage   77.37%   76.78%   -0.59%     
==========================================
  Files         202      227      +25     
  Lines       11602    12976    +1374     
  Branches     1961     2164     +203     
==========================================
+ Hits         8977     9964     +987     
- Misses       2043     2373     +330     
- Partials      582      639      +57     
Flag Coverage Δ
entityemailer 71.00% <56.98%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/config.py 94.73% <ø> (-0.14%) ⬇️
legal-api/src/legal_api/core/filing.py 86.50% <ø> (ø)
legal-api/src/legal_api/core/meta/filing.py 91.11% <ø> (ø)
legal-api/src/legal_api/models/__init__.py 100.00% <ø> (ø)
legal-api/src/legal_api/models/dc_connection.py 88.88% <ø> (ø)
legal-api/src/legal_api/models/dc_definition.py 90.47% <ø> (-0.23%) ⬇️
...l-api/src/legal_api/models/dc_issued_credential.py 87.50% <ø> (-0.31%) ⬇️
legal-api/src/legal_api/reports/report.py 26.35% <ø> (ø)
...ources/v2/business/business_digital_credentials.py 75.00% <ø> (+4.41%) ⬆️
...s/v2/business/business_filings/business_filings.py 59.20% <ø> (-0.09%) ⬇️
... and 14 more

... and 19 files with indirect coverage changes

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bolyachevets bolyachevets merged commit 821f907 into bcgov:main Nov 21, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants