Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint for Business AR to call to automatically update Co… #2974

Conversation

EPortman
Copy link
Contributor

@EPortman EPortman commented Sep 9, 2024

Ticket: https://app.zenhub.com/workspaces/annual-report-filing-for-corporations-661483a4f4f833001637ec44/issues/gh/bcgov/business-ar/314

Description of changes:
Added an endpoint to the colin-api for Business AR to call.

  • Endpoint is called after Business AR batch job sends an email to an incorporation
  • Endpoint returns an error and does nothing if corporation does not exist or if the set_ar_ind flag is already set to 'N'
  • Else, updates this flag in the corporation table to N and inserts a record for the corporation into the set_ar_to_no table

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@EPortman
Copy link
Contributor Author

EPortman commented Sep 9, 2024

@vysakh-menon-aot let me know what you think of this whenever you get a spare moment.
Thanks in advance.

@@ -22,4 +22,4 @@
Development release segment: .devN
"""

__version__ = '2.123.0' # pylint: disable=invalid-name
__version__ = '2.123.1' # pylint: disable=invalid-name
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update version in each pr (in lear repo). This will be updated together with other apps (in lear repo) before each release.

Copy link
Collaborator

@vysakh-menon-aot vysakh-menon-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vysakh-menon-aot
Copy link
Collaborator

Can you fix the lint error

@EPortman EPortman force-pushed the 314_confirm_ar_reminder_batch_job_automatically_updates_colin branch from aeaef8b to 2304361 Compare September 9, 2024 22:54
Copy link

sonarqubecloud bot commented Sep 9, 2024

@vysakh-menon-aot vysakh-menon-aot merged commit a14ac1a into bcgov:main Sep 9, 2024
6 checks passed
@EPortman
Copy link
Contributor Author

EPortman commented Sep 9, 2024

Thanks for the help, @vysakh-menon-aot

@EPortman EPortman deleted the 314_confirm_ar_reminder_batch_job_automatically_updates_colin branch September 9, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants