-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add endpoint for Business AR to call to automatically update Co… #2974
feat: add endpoint for Business AR to call to automatically update Co… #2974
Conversation
@vysakh-menon-aot let me know what you think of this whenever you get a spare moment. |
colin-api/src/colin_api/version.py
Outdated
@@ -22,4 +22,4 @@ | |||
Development release segment: .devN | |||
""" | |||
|
|||
__version__ = '2.123.0' # pylint: disable=invalid-name | |||
__version__ = '2.123.1' # pylint: disable=invalid-name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update version in each pr (in lear repo). This will be updated together with other apps (in lear repo) before each release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Can you fix the lint error |
…lin after sending email reminder
aeaef8b
to
2304361
Compare
Quality Gate passedIssues Measures |
Thanks for the help, @vysakh-menon-aot |
Ticket: https://app.zenhub.com/workspaces/annual-report-filing-for-corporations-661483a4f4f833001637ec44/issues/gh/bcgov/business-ar/314
Description of changes:
Added an endpoint to the
colin-api
for Business AR to call.set_ar_ind
flag is already set to 'N'corporation
table toN
and inserts a record for the corporation into theset_ar_to_no
tableBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).