24121 colin sync for correction filing (1 to many) #3060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vysakh-menon-aot
requested review from
argush3,
chenhongjing and
ketaki-deodhar
|
vysakh-menon-aot
commented
Nov 5, 2024
| address_type=db_address_type | ||
| ) | ||
| address = Address( | ||
| street=address_info.get('streetAddress') or '', |
There was a problem hiding this comment.
setting props to empty string if None to avoid creation of new version in the version table if the current version has empty string or vice versa. will be updating existing data through update db script
There was a problem hiding this comment.
@argush3 this need to be addressed in data migration as well.
ketaki-deodhar
approved these changes
Nov 5, 2024
chenhongjing
approved these changes
Nov 6, 2024
argush3
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#24121
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).